opendev/system-config
Code Issues Proposed changes

Set stop_grace_period on nodepool-builder containers

Browse Source 
By default docker-compose sends a sigterm to containers when they are
stopping. It then waitsfor 10 seconds before sending a sigkill. Our
nodepool-builder containers are restarted when new images are available
and if that happens during a dib build we leak contents into dib_tmp.
One theory is that we aren't giving dib enough time to clean up after
itself so increase the 10 second period before sending sigkill to 90
seconds.

I'm not sure if this will actually help, but it can't hurt much. If the
processes die quicker we don't go any slower and if they don't die
quicker then we're giving them more time to clean up.

Change-Id: Id12cac89cccfc14a8d262e8f8494046df777a80a
This commit is contained in:
Clark Boylan 2021-01-21 15:12:15 -08:00
parent da665b5b02
commit 326e0dc4d7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
playbooks/roles/nodepool-builder/templates/docker-compose.yaml.j2
View File

@ -5,6 +5,7 @@ services:
user: nodepool user: nodepool
network_mode: host network_mode: host
restart: always restart: always
stop_grace_period: 90s
command: nodepool-builder -f -c /etc/nodepool/nodepool.yaml -l /etc/nodepool/builder-logging.conf --upload-workers 8 command: nodepool-builder -f -c /etc/nodepool/nodepool.yaml -l /etc/nodepool/builder-logging.conf --upload-workers 8
privileged: true privileged: true