opendev/system-config
Code Issues Proposed changes

ask.o.o: Fix two issues with ro message

Browse Source 
1) The string is interpolated into JavaScript string which is
   delimited using double quotation marks - using double quotation
   marks in it breaks JavaScript parsing. The impact is unknown
   but at least some JavaScript code does not get executed later.

2) The anchor was unproperly closed causing void anchor to appear.
   This is clearly visible on the rendered page.

Change-Id: I90cdcdd81c6af67f940c1811b1b9c05f9309ba15
This commit is contained in:
Radosław Piliszek 2021-01-28 20:27:19 +01:00
parent 30c05ebeb1
commit 34ee1a56d9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/openstack_project/templates/askbot/settings.py.erb
View File

@ -369,9 +369,9 @@ LIVESETTINGS_OPTIONS = {
'READ_ONLY_MODE_ENABLED': True,
'READ_ONLY_MESSAGE':
'The ask.openstack.org website will be read-only from '
'now on. Please ask questions on the <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-discuss">openstack-discuss</a> '
'mailing-list, <a href="https://stackoverflow.com/questions/tagged/openstack">stackoverflow.com</a> for coding or '
'<a href="https://serverfault.com/tags/openstack/info">serverfault.com<a> for operations.'
'now on. Please ask questions on the <a href=\'http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-discuss\'>openstack-discuss</a> '
'mailing-list, <a href=\'https://stackoverflow.com/questions/tagged/openstack\'>stackoverflow.com</a> for coding or '
'<a href=\'https://serverfault.com/tags/openstack/info\'>serverfault.com</a> for operations.'
},
'GENERAL_SKIN_SETTINGS': {
<% if @custom_theme_enabled %>