Don't install puppet modules when we don't need them

We are currently cloning all of the puppet modules in install-ansible,
but we only need them when we run run-puppet. Move the cloning there
so that we can stop wasting the time in CI jobs that don't need them.
In prod, this should not have much impact.

Change-Id: I641ffc09e9e0801e0bc2469ceec97820ba354160

playbooks/roles/install-ansible/tasks/main.yaml

@@ -142,11 +142,6 @@
     - install_modules.sh
     - modules.env
 
-- name: Run puppet module install
-  command:
-    cmd: bash install_modules.sh
-    chdir: /etc/puppet
-
 - name: Copy yamlgroup inventory in place
   copy:
     src: inventory_plugins/yamlgroup.py

playbooks/roles/run-puppet/tasks/main.yaml

@@ -7,5 +7,13 @@
     name: puppet-install
 - include_role:
     name: disable-puppet-agent
+
+- name: Run puppet module install
+  delegate_to: localhost
+  run_once: true
+  command:
+    cmd: bash install_modules.sh
+    chdir: /etc/puppet
+
 - include_role:
     name: puppet