From 8ff2dbe1c353b1b79331e69a35a27103e3ef847a Mon Sep 17 00:00:00 2001
From: K Jonathan Harker <k.jonathan.harker@hp.com>
Date: Wed, 6 Aug 2014 17:53:19 -0700
Subject: [PATCH] Start running bashate on config (nonvoting)

Add bashate to test-requirements.txt, add a tox env for bashate,  and start
running it on config. Also convert devstack to run bashate via tox rather than
via run_tests.sh (the needed tox.ini changes to devstack have already merged).

Change-Id: I205d675ff231c0403dd135eacc8d57b45317859f
---
 .../jenkins_job_builder/config/macros.yaml    |  3 ++-
 .../jenkins_job_builder/config/projects.yaml  |  1 +
 .../files/slave_scripts/run-bashate.sh        | 19 -------------------
 .../openstack_project/files/zuul/layout.yaml  |  3 +++
 test-requirements.txt                         |  1 +
 tox.ini                                       |  2 ++
 6 files changed, 9 insertions(+), 20 deletions(-)
 delete mode 100755 modules/openstack_project/files/slave_scripts/run-bashate.sh

diff --git a/modules/openstack_project/files/jenkins_job_builder/config/macros.yaml b/modules/openstack_project/files/jenkins_job_builder/config/macros.yaml
index 7895b7fb34..60debe82e5 100644
--- a/modules/openstack_project/files/jenkins_job_builder/config/macros.yaml
+++ b/modules/openstack_project/files/jenkins_job_builder/config/macros.yaml
@@ -62,7 +62,8 @@
 - builder:
     name: bashate
     builders:
-      - shell: "/usr/local/jenkins/slave_scripts/run-bashate.sh"
+      - tox:
+          envlist: bashate
 
 - builder:
     name: pep8
diff --git a/modules/openstack_project/files/jenkins_job_builder/config/projects.yaml b/modules/openstack_project/files/jenkins_job_builder/config/projects.yaml
index 665b005bc8..9b7034fdf9 100644
--- a/modules/openstack_project/files/jenkins_job_builder/config/projects.yaml
+++ b/modules/openstack_project/files/jenkins_job_builder/config/projects.yaml
@@ -275,6 +275,7 @@
       - gate-{name}-puppet-syntax
       - gate-{name}-puppet-apply
       - gate-{name}-pep8
+      - gate-{name}-bashate
       - experimental-swift-logs-{name}-pep8
 
 - project:
diff --git a/modules/openstack_project/files/slave_scripts/run-bashate.sh b/modules/openstack_project/files/slave_scripts/run-bashate.sh
deleted file mode 100755
index 8b28e14630..0000000000
--- a/modules/openstack_project/files/slave_scripts/run-bashate.sh
+++ /dev/null
@@ -1,19 +0,0 @@
-#!/bin/bash -xe
-
-# Copyright 2013 OpenStack Foundation
-#
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
-# not use this file except in compliance with the License. You may obtain
-# a copy of the License at
-#
-#      http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-
-set -o pipefail
-./run_tests.sh
-set +o pipefail
diff --git a/modules/openstack_project/files/zuul/layout.yaml b/modules/openstack_project/files/zuul/layout.yaml
index 5c465147e9..2d3fbf919c 100644
--- a/modules/openstack_project/files/zuul/layout.yaml
+++ b/modules/openstack_project/files/zuul/layout.yaml
@@ -730,6 +730,8 @@ jobs:
     branch: ^(?!stable/(havana|icehouse)).*$
   - name: gate-nova-pip-missing-reqs
     voting: false
+  - name: gate-config-bashate
+    voting: false
 
 # The project list is grouped by type of project, and within each
 # group, projects are sorted (mostly) alphabetically.
@@ -2849,6 +2851,7 @@ projects:
       - config-compare-xml
       - gate-config-layout
       - gate-config-pep8
+      - gate-config-bashate
       - gate-config-puppet-syntax
       - gate-config-puppet-apply-precise
       - gate-config-puppet-apply-centos6
diff --git a/test-requirements.txt b/test-requirements.txt
index 3e36c602a9..27499c0368 100644
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -2,3 +2,4 @@ hacking>=0.5.6,<0.8
 sphinx>=1.1.2,<1.2
 docutils==0.9.1
 oslosphinx
+bashate>=0.2
diff --git a/tox.ini b/tox.ini
index 34f9788932..462958ddc2 100644
--- a/tox.ini
+++ b/tox.ini
@@ -54,3 +54,5 @@ commands =
   {toxinidir}/tools/check_projects_yaml_alphabetized.sh
   {toxinidir}/tools/run-layout.sh openstack-infra config
 
+[testenv:bashate]
+commands = bashate -v