Clean up of minor puppet-lint warnings.
Mostly documentation and parameterised class parameter complaints. Change-Id: I5b3ffa4ad3f707f385165c2d86c891c6bd4c1ae0 Reviewed-on: https://review.openstack.org/16901 Reviewed-by: James E. Blair <corvus@inaugust.com> Approved: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Tested-by: Jenkins
This commit is contained in:
Matthew Wagoner
Jenkins
parent
a8ee83d77a
commit
4f433a021f
|
|
@ -47,7 +47,7 @@ class etherpad_lite (
|
|||
require => [
|
||||
Package['git'],
|
||||
File["${base_install_dir}"],
|
||||
],
|
||||
],
|
||||
}
|
||||
|
||||
package { [
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
# == Class: etherpad_lite::mysql
|
||||
#
|
||||
class etherpad_lite::mysql(
|
||||
$database_password,
|
||||
$database_password = '',
|
||||
$dbType = 'mysql',
|
||||
$database_user = 'eplite',
|
||||
$database_name = 'etherpad-lite'
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
# == Class: etherpad_lite::site
|
||||
#
|
||||
class etherpad_lite::site (
|
||||
$database_password,
|
||||
$database_password = '',
|
||||
$dbType = 'mysql',
|
||||
$database_user = 'eplite',
|
||||
$database_name = 'etherpad-lite'
|
||||
|
|
|
|||
|
|
@ -1,16 +1,18 @@
|
|||
# == Class: gerritbot
|
||||
#
|
||||
class gerritbot(
|
||||
$nick,
|
||||
$password,
|
||||
$server,
|
||||
$user,
|
||||
$vhost_name
|
||||
$nick = '',
|
||||
$password = '',
|
||||
$server = '',
|
||||
$user = '',
|
||||
$vhost_name = ''
|
||||
) {
|
||||
include pip
|
||||
|
||||
package { 'gerritbot':
|
||||
ensure => present, # Pip upgrade is not working
|
||||
provider => pip,
|
||||
require => Class['pip']
|
||||
require => Class['pip'],
|
||||
}
|
||||
|
||||
file { '/etc/init.d/gerritbot':
|
||||
|
|
@ -30,7 +32,7 @@ class gerritbot(
|
|||
subscribe => [
|
||||
Package['gerritbot'],
|
||||
File['/etc/gerritbot/gerritbot.config'],
|
||||
File['/etc/gerritbot/channel_config.yaml']
|
||||
File['/etc/gerritbot/channel_config.yaml'],
|
||||
],
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1,7 +1,9 @@
|
|||
# == Class: launchpad_sync
|
||||
#
|
||||
class launchpad_sync(
|
||||
$root_team,
|
||||
$script_logging_conf,
|
||||
$site,
|
||||
$root_team = '',
|
||||
$script_logging_conf = '',
|
||||
$site = '',
|
||||
$script_key_file = '/home/gerrit2/.ssh/id_rsa',
|
||||
$script_user = 'update',
|
||||
$user = 'gerrit2'
|
||||
|
|
|
|||
|
|
@ -1,3 +1,5 @@
|
|||
# == Define: logrotate::file
|
||||
#
|
||||
define logrotate::file( $log,
|
||||
$options,
|
||||
$ensure=present,
|
||||
|
|
|
|||
|
|
@ -1,5 +1,7 @@
|
|||
# == Class: logrotate
|
||||
#
|
||||
# Adapted from http://projects.puppetlabs.com/projects/1/wiki/Logrotate_Patterns
|
||||
|
||||
#
|
||||
class logrotate {
|
||||
package { 'logrotate':
|
||||
ensure => present,
|
||||
|
|
|
|||
|
|
@ -1,11 +1,11 @@
|
|||
# == Class: puppetboot
|
||||
#
|
||||
class puppetboot($ensure=present) {
|
||||
file {'/etc/init/puppetboot.conf':
|
||||
owner => 'root',
|
||||
group => 'root',
|
||||
mode => 644,
|
||||
ensure => $ensure,
|
||||
source => [
|
||||
"puppet:///modules/puppetboot/puppetboot.conf",
|
||||
],
|
||||
owner => 'root',
|
||||
group => 'root',
|
||||
mode => '0644',
|
||||
source => 'puppet:///modules/puppetboot/puppetboot.conf',
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,3 +1,5 @@
|
|||
# == Class: ssh
|
||||
#
|
||||
class ssh {
|
||||
package { 'openssh-server':
|
||||
ensure => present,
|
||||
|
|
@ -8,12 +10,14 @@ class ssh {
|
|||
subscribe => File['/etc/ssh/sshd_config'],
|
||||
}
|
||||
file { '/etc/ssh/sshd_config':
|
||||
ensure => present,
|
||||
owner => 'root',
|
||||
group => 'root',
|
||||
mode => '0444',
|
||||
source => [ "puppet:///modules/ssh/sshd_config.${::operatingsystem}",
|
||||
'puppet:///modules/ssh/sshd_config' ],
|
||||
ensure => present,
|
||||
owner => 'root',
|
||||
group => 'root',
|
||||
mode => '0444',
|
||||
source => [
|
||||
"puppet:///modules/ssh/sshd_config.${::operatingsystem}",
|
||||
'puppet:///modules/ssh/sshd_config',
|
||||
],
|
||||
replace => true,
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,3 +1,5 @@
|
|||
# == Class: sudoers
|
||||
#
|
||||
class sudoers {
|
||||
group { 'sudo':
|
||||
ensure => present,
|
||||
|
|
|
|||
|
|
@ -1,3 +1,5 @@
|
|||
# == Define: ulimit::conf
|
||||
#
|
||||
define ulimit::conf (
|
||||
$limit_domain,
|
||||
$limit_item,
|
||||
|
|
@ -10,8 +12,7 @@ define ulimit::conf (
|
|||
content => template('ulimit/limits.erb'),
|
||||
replace => true,
|
||||
owner => 'root',
|
||||
mode => 0644,
|
||||
require => File['/etc/security/limits.d']
|
||||
mode => '0644',
|
||||
require => File['/etc/security/limits.d'],
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,13 +1,14 @@
|
|||
# == Class: ulimit
|
||||
#
|
||||
class ulimit {
|
||||
|
||||
package { ['libpam-modules', 'libpam-modules-bin']:
|
||||
ensure => present
|
||||
ensure => present,
|
||||
}
|
||||
|
||||
file { '/etc/security/limits.d':
|
||||
ensure => directory,
|
||||
owner => 'root',
|
||||
mode => 0755
|
||||
mode => '0755',
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,11 +1,12 @@
|
|||
# == Class: zuul
|
||||
#
|
||||
class zuul (
|
||||
$jenkins_server,
|
||||
$jenkins_user,
|
||||
$jenkins_apikey,
|
||||
$gerrit_server,
|
||||
$gerrit_user,
|
||||
$url_pattern,
|
||||
$jenkins_server = '',
|
||||
$jenkins_user = '',
|
||||
$jenkins_apikey = '',
|
||||
$gerrit_server = '',
|
||||
$gerrit_user = '',
|
||||
$url_pattern = '',
|
||||
$status_url = "https://${::fqdn}/zuul/status",
|
||||
$git_source_repo = 'https://github.com/openstack-ci/zuul.git',
|
||||
$push_change_refs = false
|
||||
|
|
|
|||
Loading…
Reference in New Issue