Clean up of minor puppet-lint warnings.

Mostly documentation and parameterised class parameter complaints.

Change-Id: I5b3ffa4ad3f707f385165c2d86c891c6bd4c1ae0
Reviewed-on: https://review.openstack.org/16901
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins

modules/etherpad_lite/manifests/mysql.pp

@@ -1,7 +1,7 @@
 # == Class: etherpad_lite::mysql
 #
 class etherpad_lite::mysql(
-  $database_password,
+  $database_password = '',
   $dbType = 'mysql',
   $database_user = 'eplite',
   $database_name = 'etherpad-lite'

modules/etherpad_lite/manifests/site.pp

@@ -1,7 +1,7 @@
 # == Class: etherpad_lite::site
 #
 class etherpad_lite::site (
-  $database_password,
+  $database_password = '',
   $dbType = 'mysql',
   $database_user = 'eplite',
   $database_name = 'etherpad-lite'

modules/gerritbot/manifests/init.pp

@@ -1,16 +1,18 @@
+# == Class: gerritbot
+#
 class gerritbot(
-  $nick,
+  $nick = '',
-  $password,
+  $password = '',
-  $server,
+  $server = '',
-  $user,
+  $user = '',
-  $vhost_name
+  $vhost_name = ''
 ) {
   include pip
 
   package { 'gerritbot':
     ensure   => present,  # Pip upgrade is not working
     provider => pip,
-    require  => Class['pip']
+    require  => Class['pip'],
   }
 
   file { '/etc/init.d/gerritbot':
@@ -30,7 +32,7 @@ class gerritbot(
     subscribe  => [
       Package['gerritbot'],
       File['/etc/gerritbot/gerritbot.config'],
-      File['/etc/gerritbot/channel_config.yaml']
+      File['/etc/gerritbot/channel_config.yaml'],
     ],
   }
 

modules/launchpad_sync/manifests/init.pp

@@ -1,7 +1,9 @@
+# == Class: launchpad_sync
+#
 class launchpad_sync(
-  $root_team,
+  $root_team = '',
-  $script_logging_conf,
+  $script_logging_conf = '',
-  $site,
+  $site = '',
   $script_key_file = '/home/gerrit2/.ssh/id_rsa',
   $script_user = 'update',
   $user = 'gerrit2'

modules/logrotate/manifests/file.pp

@@ -1,3 +1,5 @@
+# == Define: logrotate::file
+#
 define logrotate::file( $log,
   $options,
   $ensure=present,

modules/logrotate/manifests/init.pp

@@ -1,5 +1,7 @@
+# == Class: logrotate
+#
 # Adapted from http://projects.puppetlabs.com/projects/1/wiki/Logrotate_Patterns
-
+#
 class logrotate {
   package { 'logrotate':
     ensure => present,

modules/puppetboot/manifests/init.pp

@@ -1,11 +1,11 @@
+# == Class: puppetboot
+#
 class puppetboot($ensure=present) {
   file {'/etc/init/puppetboot.conf':
+    ensure => $ensure,
     owner  => 'root',
     group  => 'root',
-    mode => 644,
+    mode   => '0644',
-    ensure => $ensure,
+    source => 'puppet:///modules/puppetboot/puppetboot.conf',
-    source => [
-      "puppet:///modules/puppetboot/puppetboot.conf",
-    ],
   }
 }

modules/ssh/manifests/init.pp

@@ -1,3 +1,5 @@
+# == Class: ssh
+#
 class ssh {
     package { 'openssh-server':
       ensure => present,
@@ -12,8 +14,10 @@ class ssh {
       owner   => 'root',
       group   => 'root',
       mode    => '0444',
-      source => [ "puppet:///modules/ssh/sshd_config.${::operatingsystem}",
+      source  => [
-                  'puppet:///modules/ssh/sshd_config' ],
+        "puppet:///modules/ssh/sshd_config.${::operatingsystem}",
+        'puppet:///modules/ssh/sshd_config',
+      ],
       replace => true,
     }
 }

modules/sudoers/manifests/init.pp

@@ -1,3 +1,5 @@
+# == Class: sudoers
+#
 class sudoers {
   group { 'sudo':
     ensure => present,

modules/ulimit/manifests/conf.pp

@@ -1,3 +1,5 @@
+# == Define: ulimit::conf
+#
 define ulimit::conf (
   $limit_domain,
   $limit_item,
@@ -10,8 +12,7 @@ define ulimit::conf (
     content => template('ulimit/limits.erb'),
     replace => true,
     owner   => 'root',
-    mode    => 0644,
+    mode    => '0644',
-    require => File['/etc/security/limits.d']
+    require => File['/etc/security/limits.d'],
   }
-
 }

modules/ulimit/manifests/init.pp

@@ -1,13 +1,14 @@
+# == Class: ulimit
+#
 class ulimit {
 
   package { ['libpam-modules', 'libpam-modules-bin']:
-    ensure => present
+    ensure => present,
   }
 
   file { '/etc/security/limits.d':
     ensure => directory,
     owner  => 'root',
-    mode   => 0755
+    mode   => '0755',
   }
-
 }

modules/zuul/manifests/init.pp

@@ -1,11 +1,12 @@
 # == Class: zuul
+#
 class zuul (
-  $jenkins_server,
+  $jenkins_server = '',
-  $jenkins_user,
+  $jenkins_user = '',
-  $jenkins_apikey,
+  $jenkins_apikey = '',
-  $gerrit_server,
+  $gerrit_server = '',
-  $gerrit_user,
+  $gerrit_user = '',
-  $url_pattern,
+  $url_pattern = '',
   $status_url = "https://${::fqdn}/zuul/status",
   $git_source_repo = 'https://github.com/openstack-ci/zuul.git',
   $push_change_refs = false