opendev/system-config
Code Issues Proposed changes

Allow links in the message

Browse Source 
The negative matching group that's supposed to prevent the closing li
tag from matching gets confused when there is a link in the text. It
only matches up to the beginning of the link, but then there is no li
closing tag after that, so hijinx ensue.

Just replace it with a .* since the regex is already anchored by the
closing li tag.

Change-Id: I030b2f00189e1ffed9981b1c3e4540306517e1bf
This commit is contained in:
Monty Taylor 2016-12-09 16:01:24 -06:00
parent 09675753c1
commit 50dcf771b9
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/openstack_project/manifests/review.pp
View File

@ -177,7 +177,7 @@ class openstack_project::review (
}, },
{ {
name => 'testresult', name => 'testresult',
match => '<li>([^ ]+) <a href=\"[^\"]+\" target=\"_blank\" rel=\"nofollow\">([^<]+)</a> : ([^ ]+)([^<]*)</li>', match => '<li>([^ ]+) <a href=\"[^\"]+\" target=\"_blank\" rel=\"nofollow\">([^<]+)</a> : ([^ ]+)(.*)</li>',
html => '<li class=\"comment_test\"><span class=\"comment_test_name\"><a href=\"$2\" rel=\"nofollow\">$1</a></span> <span class=\"comment_test_result\"><span class=\"result_$3\">$3</span>$4</span></li>', html => '<li class=\"comment_test\"><span class=\"comment_test_name\"><a href=\"$2\" rel=\"nofollow\">$1</a></span> <span class=\"comment_test_result\"><span class=\"result_$3\">$3</span>$4</span></li>',
}, },
{ {