Merge "Use openstack_project::server class where possible"

manifests/site.pp

@@ -258,6 +258,12 @@ node 'groups-dev.openstack.org' {
 
 # Node-OS: trusty
 node 'lists.openstack.org' {
+  class { 'openstack_project::server':
+    iptables_public_tcp_ports => [25, 80, 465],
+    manage_exim => false,
+    purge_apt_sources => false,
+  }
+
   class { 'openstack_project::lists':
     listadmins   => hiera('listadmins', []),
     listpassword => hiera('listpassword'),
@@ -1287,6 +1293,11 @@ node 'pbx.openstack.org' {
 # A backup machine.  Don't run cron or puppet agent on it.
 node /^ci-backup-.*\.openstack\.org$/ {
   $group = "ci-backup"
+  class { 'openstack_project::server':
+    iptables_public_tcp_ports => [],
+    manage_exim => false,
+    purge_apt_sources => false,
+  }
   include openstack_project::backup_server
 }
 

modules/openstack_project/manifests/backup_server.pp

@@ -1,9 +1,6 @@
 # == Class: openstack_project::backup_server
 #
 class openstack_project::backup_server {
-  class { 'openstack_project::template':
-    iptables_public_tcp_ports => [],
-  }
   package { 'bup':
     ensure => present,
   }

modules/openstack_project/manifests/lists.pp

@@ -4,13 +4,6 @@ class openstack_project::lists(
   $listadmins,
   $listpassword = ''
 ) {
-  # Using openstack_project::template instead of openstack_project::server
-  # because the exim config on this machine is almost certainly
-  # going to be more complicated than normal.
-  class { 'openstack_project::template':
-    iptables_public_tcp_ports => [25, 80, 465],
-  }
-
   $listdomain = 'lists.openstack.org'
 
   class { 'exim':

modules/openstack_project/manifests/puppetdb.pp

@@ -22,7 +22,7 @@ class openstack_project::puppetdb (
 
   class { 'puppetdb::database::postgresql':
     require         => [User['postgres'],
-      Class['openstack_project::template'],],
+      Class['openstack_project::server'],],
   }
 
   class { '::puppetdb::server':