diff --git a/doc/source/gerrit.rst b/doc/source/gerrit.rst index 4a2ffc259e..674d05ac0b 100644 --- a/doc/source/gerrit.rst +++ b/doc/source/gerrit.rst @@ -17,14 +17,13 @@ At a Glance =========== :Hosts: - * http://review.opendev.org - * http://review-dev.openstack.org -:Puppet: - * https://opendev.org/opendev/puppet-gerrit - * :git_file:`modules/openstack_project/manifests/review.pp` - * :git_file:`modules/openstack_project/manifests/review_dev.pp` + * https://review.opendev.org + * https://review-dev.opendev.org +:Ansbile: + * :git_file:`playbooks/service-review.yaml` + * :git_file:`playbooks/roles/gerrit` :Configuration: - * :git_file:`modules/openstack_project/templates/review.projects.ini.erb` + * :git_file:`playbooks/roles/gerrit/templates/projects.ini.j2` * :config:`gerrit/projects.yaml` :Projects: * http://code.google.com/p/gerrit/ @@ -37,9 +36,8 @@ At a Glance Installation ============ -Gerrit is installed and configured by Puppet, including specifying the -exact Java WAR file that is used. See :ref:`sysadmin` for how Puppet -is used to manage OpenStack infrastructure systems. +Gerrit is installed and configured by Ansible, using a Docker container +that contains the Java WAR file. Cinder Volumes -------------- @@ -103,7 +101,7 @@ account name and add ssh keys - you'll need those. Once you've created your groups you should create the ``openstack-project-creator`` account by hand (the account name is referenced from -:git_file:`modules/openstack_project/templates/review.projects.ini.erb`) +:git_file:`playbooks/roles/gerrit/templates/projects.ini.j2`) using:: cat $pubkey | ssh -p 29418 $USER@$HOST gerrit create-account \ @@ -152,21 +150,6 @@ After the team has been added, project will start replicating successfully to GitHub. -Auto Review Expiry -================== - -Puppet automatically installs a daily cron job called ``expire-old-reviews`` -onto the Gerrit servers. This script follows two rules: - -#. If the review hasn't been touched in 2 weeks, mark as abandoned. -#. If there is a negative review and it hasn't been touched in 1 week, mark as - abandoned. - -If your review gets touched by either of these rules, it is possible to -unabandon a review on the Gerrit web interface. - -This process is managed by the :ref:`jeepyb` openstack-infra project. - Gerrit IRC Bot ============== @@ -446,15 +429,8 @@ To rename a project: Add this file to the ``renames/`` directory in the ``opendev/project-config`` repository. -#. An hour in advance of the maintenance (if possible), stop puppet - runs on the puppetmaster to prevent early application of - configuration changes:: - - sudo crontab -u root -e - - Comment out the crontab entries. Use ps to make sure that a run is - not currently in progress. When it finishes, make sure the entry - has not been added back to the crontab. +#. An hour in advance of the maintenance (if possible), put + ``review01.opendev.org`` into the emergency file on bridge. #. Run the ansible rename repos playbook, passing in the path to your yaml file:: @@ -466,9 +442,7 @@ To rename a project: #. Rename the project or transfer ownership in GitHub -#. Re-enable puppet runs on the puppetmaster:: - - sudo crontab -u root -e +#. Remove ``review01.opendev.org`` from the emergency file. .. warning:: Wait for the ``project-config`` changes to merge before diff --git a/modules.env b/modules.env index 337e57dd43..339921b133 100644 --- a/modules.env +++ b/modules.env @@ -76,7 +76,6 @@ INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-elasticsearch"]="origin/ INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-ethercalc"]="origin/master" INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-exim"]="origin/master" INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-germqtt"]="origin/master" -INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-gerrit"]="origin/master" INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-gerritbot"]="origin/master" INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-github"]="origin/master" INTEGRATION_MODULES["$OPENSTACK_GIT_ROOT/opendev/puppet-grafyaml"]="origin/master" diff --git a/modules/openstack_project/files/gerrit/GerritSite.css b/modules/openstack_project/files/gerrit/GerritSite.css deleted file mode 100644 index c1c9d47575..0000000000 --- a/modules/openstack_project/files/gerrit/GerritSite.css +++ /dev/null @@ -1,179 +0,0 @@ -body {color: #000 !important;} -a,a:visited {color: #264D69 !important; text-decoration: none;} -a:hover {color: #000 !important; text-decoration: underline} - -a.gwt-InlineHyperlink {background: none !important} - -#openstack-logo img { height: 40px; } -#openstack-logo h1 { margin: 20px; } -#gerrit_header #openstack-logo h1 { margin: 20px 0 0 0; } - -#gerrit_header {display: block !important; position: relative; top: -60px; margin-bottom: -60px; width: 200px; padding-left: 17px} -#gerrit_header h1 {font-family: 'PT Sans', sans-serif; font-weight: normal; letter-spacing: -1px} - -#gerrit_topmenu {background: none; position:relative; top: 0px; left: 220px; margin-right: 220px} - -#gerrit_topmenu tbody tr td table {border: 0} - -#gerrit_topmenu tbody tr td table.gwt-TabBar {color: #353535; border-bottom: 1px solid #C5E2EA;} -#gerrit_topmenu .gwt-Button {padding: 3px 6px} -.gwt-TabBarItem-selected {color: #CF2F19 !important; border-bottom: 3px solid #CF2F19;} -.gwt-TabBarItem {color: #353535; border-right: 0 !important} -.gwt-TabBar .gwt-TabBarItem, .gwt-TabBar .gwt-TabBarRest, .gwt-TabPanelBottom {background: 0 !important;} - -#gerrit_topmenu .searchTextBox {width: 250px} - -#change_infoTable { - border-collapse: collapse; -} - -#change_infoTable th { - padding: 2px 4px 2px 6px; - background-color: #eef3f5; - font-style: italic; - text-align: left; -} - -#change_infoTable td { - padding: 2px 4px 2px 6px; - border-bottom: 1px solid #eef3f5; - border-right: 1px solid #eef3f5; -} - -#change_infoTable tr:last-child td { - border: none; -} - -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 { - padding-left: 10px; - padding-right: 10px; -} - -/* Section headers */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-headerLine, -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-sectionHeader { - margin-top: 10px !important; - margin-bottom: 10px !important; -} - -/* Commit message */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-text::first-line { - font-weight: bold !important; -} - -/* Commit metadata */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-commitColumn - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header th { - padding: 2px 4px 2px 6px; - background-color: #eef3f5; - font-style: italic; - text-align: left; -} - -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-commitColumn - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header td { - border-bottom: 1px solid #eef3f5; - padding: 2px 4px 2px 6px; -} - -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-commitColumn - .com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header td:last-child { - border-right: 1px solid #eef3f5; -} - -/* increase the middle info column to fill empty space (for wide -monitors), but ensure there is a sufficient lower bound to kick in -horiz scroll bar. This will relieve the preasure on the hideci test -results. */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-infoColumn { - width: 100% !important; - min-width: 400px; -} - -/* Review history */ -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-Message_BinderImpl_GenCss_style-name { - font-weight: bold !important; -} -.com-google-gerrit-client-change-ChangeScreen_BinderImpl_GenCss_style-cs2 - .com-google-gerrit-client-change-Message_BinderImpl_GenCss_style-messageBox { - width: inherit; - max-width: 1168px; -} - -.comment_test_name { - display: inline-block; - *display: inline; - *zoom: 1; - width: auto !important; - width: 25em; - min-width: 20em; - padding-bottom: 2pt; -} - -.comment_test_result { -} - -.result_SUCCESS { - color: #007f00; -} -.result_FAILURE, .result_POST_FAILURE, .result_TIMED_OUT, .result_RETRY_LIMIT, .result_DISK_FULL { - color: #cf2f19; -} -.result_UNSTABLE, .result_WARNING { - color: #e39f00; -} -.result_LOST { - color: #e39f00; -} -li.comment_test {list-style-type: none; } - -/* this is for support of 'Display Person Name In Review Category' */ -.cAPPROVAL { - max-width: 100px; - overflow: hidden; -} -/* fixes to make this like old gerrit */ -.changeTable td.dataCell { - height: 1em; -} - -/* don't make the non voting stand out more than the voting */ -table.infoTable td.notVotable, -.changeTable td.dataCell.labelNotApplicable { - background: inherit; -} - -.test_result_table { - border-collapse: collapse; -} - -.test_result_table tr { - border-left: 1px solid #eef3f5; - border-right: 1px solid #eef3f5; -} - -.test_result_table td.header { - background-color: #eef3f5; -} - -.test_result_table td { - padding: 2px 4px 2px 6px; - border: 1px solid #eef3f5; -} - -.addMemberTextBox { - width: 20em; -} - -/* css attribute selector to make -1s show up red in new screen */ -[title="Doesn't seem to work"], -[title="This patch needs further work before it can be merged"] { - color: red; -} diff --git a/modules/openstack_project/files/gerrit/GerritSiteHeader.html b/modules/openstack_project/files/gerrit/GerritSiteHeader.html deleted file mode 100644 index 0e2f060fa8..0000000000 --- a/modules/openstack_project/files/gerrit/GerritSiteHeader.html +++ /dev/null @@ -1,6 +0,0 @@ -