opendev/system-config
Code Issues Proposed changes

Remove thick_slave from single_use_slave

Browse Source 
There is nothing in system-config or the zuul worker builders that set
thin to false, so let's just clean this up so we can see more easily
what this class does.

Change-Id: Ia71cfe61850bdc89f323a2774231b4e2c709ac17
This commit is contained in:
Colleen Murphy 2017-03-25 15:05:39 +01:00
parent 1bd9635d97
commit 54ae2200e1
2 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
manifests/site.pp
View File

@ -1413,20 +1413,6 @@ node 'openstackid-dev.openstack.org' {
}
}
# Node-OS: trusty
# This is not meant to be an actual node that connects to the master.
# This is a dummy node definition to trigger a test of the code path used by
# nodepool's prepare_node scripts in the apply tests
# NOTE(pabelanger): These are the settings we currently use for bare-* nodes.
# It includes thick_slave.pp.
node 'single-use-slave-bare' {
class { 'openstack_project::single_use_slave':
# Test non-default values from prepare_node_bare.sh
sudo => true,
thin => false,
}
}
# Node-OS: centos7
# Node-OS: fedora24
# Node-OS: fedora25
@ -1440,7 +1426,6 @@ node 'single-use-slave-bare' {
node 'single-use-slave-devstack' {
class { 'openstack_project::single_use_slave':
sudo => true,
thin => true,
}
}

5
modules/openstack_project/manifests/single_use_slave.pp
View File

@ -54,9 +54,6 @@ class openstack_project::single_use_slave (
}
if (! $thin) {
class { 'openstack_project::thick_slave':
all_mysql_privs => $all_mysql_privs,
notice("The openstack_project::single_use_slave::thin parameter has no effect.")
}
}
}