From 5a3772038803343dfc5132ed9dd50673eedbc6d1 Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Wed, 6 Jul 2022 13:21:17 +0000 Subject: [PATCH] Update Mailman archive URLs to use HTTPS A missed detail of the HTTPS config migration, /usr/lib/mailman/Mailman/Defaults.py explicitly sets this: PUBLIC_ARCHIVE_URL = 'http://%(hostname)s/pipermail/%(listname)s/' Override that setting to https:// so that the archive URL embedded in E-mail headers will no longer unnecessarily rely on our Apache redirect. Once merged and deployed, fix_url.py will need to be rerun for all the lists on both servers in order for this update to take effect. Change-Id: Ie4a6e04a2ef0de1db7336a2607059a2ad42665c2 --- playbooks/roles/mailman-site/templates/mm_site_cfg.py.j2 | 1 + playbooks/roles/mailman/templates/mm_cfg.py.j2 | 1 + 2 files changed, 2 insertions(+) diff --git a/playbooks/roles/mailman-site/templates/mm_site_cfg.py.j2 b/playbooks/roles/mailman-site/templates/mm_site_cfg.py.j2 index 3f00829d3e..f7cef51f3d 100644 --- a/playbooks/roles/mailman-site/templates/mm_site_cfg.py.j2 +++ b/playbooks/roles/mailman-site/templates/mm_site_cfg.py.j2 @@ -58,6 +58,7 @@ MAILMAN_SITE_LIST = 'mailman' # If you change these, you have to configure your http server # accordingly (Alias and ScriptAlias directives in most httpds) DEFAULT_URL_PATTERN = 'https://%s/cgi-bin/mailman/' +PUBLIC_ARCHIVE_URL = 'https://%(hostname)s/pipermail/%(listname)s' PRIVATE_ARCHIVE_URL = '/cgi-bin/mailman/private' IMAGE_LOGOS = '/images/mailman/' diff --git a/playbooks/roles/mailman/templates/mm_cfg.py.j2 b/playbooks/roles/mailman/templates/mm_cfg.py.j2 index c165432728..43ad76de3e 100644 --- a/playbooks/roles/mailman/templates/mm_cfg.py.j2 +++ b/playbooks/roles/mailman/templates/mm_cfg.py.j2 @@ -58,6 +58,7 @@ MAILMAN_SITE_LIST = 'mailman' # If you change these, you have to configure your http server # accordingly (Alias and ScriptAlias directives in most httpds) DEFAULT_URL_PATTERN = 'https://%s/cgi-bin/mailman/' +PUBLIC_ARCHIVE_URL = 'https://%(hostname)s/pipermail/%(listname)s' PRIVATE_ARCHIVE_URL = '/cgi-bin/mailman/private' IMAGE_LOGOS = '/images/mailman/'