opendev/system-config
Code Issues Proposed changes

Don't restart the zuul scheduler in prod

Browse Source 
We use the zuul_scheduler_start flag to determine if we want to start
the zuul-scheduler when new containers show up. Unfortunately we weren't
setting zuul_scheduler_start in prod so we failed with this error:

  error while evaluating conditional (zuul_scheduler_start | bool): 'zuul_scheduler_start' is undefined

Fix this by treating an unset var as equivalent to a set truthy var
value. We do this instead of always setting the var to false in prod as
it simplifies testing.

Change-Id: I1f1a86e80199601646c7f2dec2a91c5d65d77231
This commit is contained in:
Clark Boylan 2020-04-28 11:14:18 -07:00
parent 81d9dc44ab
commit 5acf91a3f6
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
playbooks/roles/zuul-scheduler/handlers/main.yaml
View File

@ -2,5 +2,5 @@
shell: shell:
cmd: docker-compose exec -T scheduler zuul-scheduler smart-reconfigure cmd: docker-compose exec -T scheduler zuul-scheduler smart-reconfigure
chdir: /etc/zuul-scheduler chdir: /etc/zuul-scheduler
# Don't run a restart if we're starting zuul with the playbook # Don't run a reconfigure if we're starting zuul with the playbook
when: not zuul_scheduler_start|bool when: zuul_scheduler_start is not defined or not zuul_scheduler_start|bool

2
playbooks/roles/zuul-scheduler/tasks/main.yaml
View File

@ -70,4 +70,4 @@
- name: Start containers - name: Start containers
include_tasks: start.yaml include_tasks: start.yaml
when: zuul_scheduler_start | bool when: zuul_scheduler_start is defined and zuul_scheduler_start | bool