opendev/system-config
Code Issues Proposed changes

Fix boolean operator in submittableIf rules

Browse Source 
Gerrit 3.6 and older do not support 'and' as a boolean operator. They
only support 'AND'. For maximum compatibility (we are running 3.6.4
currently) convert 'and' to 'AND' in Gerrit submittableIf rules.

Change-Id: Iac5e2cda4a245f99e98a1354ad4107da07e1f60d
This commit is contained in:
Clark Boylan 2023-03-09 08:33:22 -08:00
parent ae7884a409
commit 64957e9e0d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/source/gerrit.rst
View File

@ -304,7 +304,7 @@ Next, edit ``project.config`` to look like::
[submit-requirement "Code-Review"]
description = Code reviewed
submittableIf = label:Code-Review=MAX and -label:Code-Review=MIN
submittableIf = label:Code-Review=MAX AND -label:Code-Review=MIN
canOverrideInChildProjects = true
[label "Verified"]
@ -317,7 +317,7 @@ Next, edit ``project.config`` to look like::
[submit-requirement "Verified"]
description = Code verified by Zuul
submittableIf = label:Verified=MAX and -label:Verified=MIN
submittableIf = label:Verified=MAX AND -label:Verified=MIN
[label "Workflow"]
function = NoBlock
@ -327,7 +327,7 @@ Next, edit ``project.config`` to look like::
[submit-requirement "Workflow"]
description = Approved by core member
submittableIf = label:Workflow=MAX and -label:Workflow=MIN
submittableIf = label:Workflow=MAX AND -label:Workflow=MIN
[plugin "its-storyboard"]
enabled = true