Merge "Add gerrit 3.8 to 3.9 upgrade testing"

playbooks/zuul/upgrade-review.yaml

@@ -7,7 +7,7 @@
 - name: Ensure initial gerrit state without starting Gerrit
   import_playbook: ../service-review.yaml
   vars:
-    gerrit_container_image: docker.io/opendevorg/gerrit:3.7
+    gerrit_container_image: docker.io/opendevorg/gerrit:3.8
     gerrit_run_init: false
     gerrit_run_reindex: false
     gerrit_run_compose_up: false
@@ -35,7 +35,7 @@
 - name: Start Gerrit on the old version of Gerrit
   import_playbook: ../service-review.yaml
   vars:
-    gerrit_container_image: docker.io/opendevorg/gerrit:3.7
+    gerrit_container_image: docker.io/opendevorg/gerrit:3.8
 
 - hosts: "review:!disabled"
   name: "Wait for gerrit to be up and running"
@@ -84,9 +84,9 @@
 - name: Perform gerrit upgrade
   import_playbook: ../service-review.yaml
   vars:
-    gerrit_container_image: docker.io/opendevorg/gerrit:3.8
+    gerrit_container_image: docker.io/opendevorg/gerrit:3.9
     gerrit_run_init: true
-    # Gerrit 3.7 -> 3.8 upgrade does not require an offline reindex
+    # Gerrit 3.8 -> 3.9 upgrade does not require an offline reindex
     gerrit_run_reindex: false
 
 - hosts: "review:!disabled"

zuul.d/project.yaml

@@ -74,13 +74,13 @@
               - name: opendev-buildset-registry
               - name: system-config-build-image-gerrit-3.9
                 soft: true
-        #- system-config-upgrade-review:
-        #    dependencies:
-        #      - name: opendev-buildset-registry
-        #      - name: system-config-build-image-gerrit-3.7
-        #        soft: true
-        #      - name: system-config-build-image-gerrit-3.8
-        #        soft: true
+        - system-config-upgrade-review:
+            dependencies:
+              - name: opendev-buildset-registry
+              - name: system-config-build-image-gerrit-3.8
+                soft: true
+              - name: system-config-build-image-gerrit-3.9
+                soft: true
         - system-config-build-image-refstack
         - system-config-run-refstack:
             dependencies:

zuul.d/system-config-run.yaml

@@ -1094,20 +1094,20 @@
     vars:
       zuul_test_gerrit_version: '3.9'
 
-#- job:
-#    name: system-config-upgrade-review
-#    parent: system-config-run-review-base
-#    description: |
-#      Test we can upgrade a gerrit 3.7 to 3.8
-#    requires:
-#      - gerrit-3.7-container-image
-#      - gerrit-3.8-container-image
-#    vars:
-#      run_playbooks:
-#        - playbooks/letsencrypt.yaml
-#        - playbooks/zuul/upgrade-review.yaml
-#      run_test_playbook: playbooks/zuul/test-review.yaml
-#      zuul_test_gerrit_version: '3.7'
+- job:
+    name: system-config-upgrade-review
+    parent: system-config-run-review-base
+    description: |
+      Test we can upgrade a gerrit 3.8 to 3.9
+    requires:
+      - gerrit-3.8-container-image
+      - gerrit-3.9-container-image
+    vars:
+      run_playbooks:
+        - playbooks/letsencrypt.yaml
+        - playbooks/zuul/upgrade-review.yaml
+      run_test_playbook: playbooks/zuul/test-review.yaml
+      zuul_test_gerrit_version: '3.8'
 
 - job:
     name: system-config-run-static