From 8a9ed04cabe52e4d00e7801effef87f8da8352b1 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 24 Sep 2020 11:28:42 -0700 Subject: [PATCH] Simplify gitea project creation control flow Previously we set strategy: free and max_fail_percentage: 1 and this probably made sense when we were using native ansible to do all of the work to create projects. That was slow and broken down into many tasks. Now however, we have a single task that calls out to a python module that does all the work for each gitea host. That means we won't get any additional parallelization from the free strategy. We also don't want to stop the python module on all hosts if any of them fail, instead let them all run to completion if they can. Then if any giteas fail we should skip the play on review. Change-Id: I1548e7946526b683d71fe4e905faabd1049f186c --- playbooks/manage-projects.yaml | 2 -- playbooks/sync-gitea-projects.yaml | 2 -- 2 files changed, 4 deletions(-) diff --git a/playbooks/manage-projects.yaml b/playbooks/manage-projects.yaml index 52849d08aa..558f2cfd21 100644 --- a/playbooks/manage-projects.yaml +++ b/playbooks/manage-projects.yaml @@ -1,7 +1,5 @@ - hosts: "gitea:!disabled" name: "Create repos on gitea servers" - strategy: free - max_fail_percentage: 1 roles: - gitea-git-repos diff --git a/playbooks/sync-gitea-projects.yaml b/playbooks/sync-gitea-projects.yaml index 484826c588..bf2e00c703 100644 --- a/playbooks/sync-gitea-projects.yaml +++ b/playbooks/sync-gitea-projects.yaml @@ -11,8 +11,6 @@ - hosts: "gitea:!disabled" name: "Create repos on gitea servers" - strategy: free - max_fail_percentage: 1 roles: - role: gitea-git-repos gitea_always_update: true