opendev/system-config
Code Issues Proposed changes

Merge "Don't manage iptables if we're in a choot"

Browse Source
This commit is contained in:
Jenkins 2014-07-05 23:08:55 +00:00 committed by Gerrit Code Review
commit 9cb87817fc
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/iptables/manifests/init.pp
View File

@ -23,6 +23,13 @@ class iptables(
name => $::iptables::params::package_name, name => $::iptables::params::package_name,
} }
if ($::in_chroot) {
notify { 'iptables in chroot':
message => 'Iptables not refreshed, running in chroot',
}
$notify_iptables = []
}
else {
service { 'iptables': service { 'iptables':
name => $::iptables::params::service_name, name => $::iptables::params::service_name,
require => Package['iptables'], require => Package['iptables'],
@ -30,6 +37,8 @@ class iptables(
status => $::iptables::params::service_status_cmd, status => $::iptables::params::service_status_cmd,
hasrestart => $::iptables::params::service_has_restart, hasrestart => $::iptables::params::service_has_restart,
} }
$notify_iptables = Service['iptables']
}
file { $::iptables::params::rules_dir: file { $::iptables::params::rules_dir:
ensure => directory, ensure => directory,
@ -49,7 +58,7 @@ class iptables(
File[$::iptables::params::rules_dir], File[$::iptables::params::rules_dir],
], ],
# When this file is updated, make sure the rules get reloaded. # When this file is updated, make sure the rules get reloaded.
notify => Service['iptables'], notify => $notify_iptables,
} }
file { $::iptables::params::ipv4_rules: file { $::iptables::params::ipv4_rules:
@ -59,7 +68,7 @@ class iptables(
mode => '0640', mode => '0640',
target => "${::iptables::params::rules_dir}/rules", target => "${::iptables::params::rules_dir}/rules",
require => File["${::iptables::params::rules_dir}/rules"], require => File["${::iptables::params::rules_dir}/rules"],
notify => Service['iptables'], notify => $notify_iptables,
} }
file { $::iptables::params::ipv6_rules: file { $::iptables::params::ipv6_rules:
@ -73,7 +82,7 @@ class iptables(
File[$::iptables::params::rules_dir], File[$::iptables::params::rules_dir],
], ],
# When this file is updated, make sure the rules get reloaded. # When this file is updated, make sure the rules get reloaded.
notify => Service['iptables'], notify => $notify_iptables,
replace => true, replace => true,
} }
} }