From 63f5674e6f1d36b3cc3d56b5a07e797947ff89b1 Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Tue, 12 Oct 2021 09:26:44 -0700
Subject: [PATCH] Switch test gerrit hostname to review99.opendev.org

Previously we had set up the test gerrit instance to use the same
hostname as production: review02.opendev.org. This causes some confusion
as we have to override settings specifically for testing like a reduced
heap size, but then also copy settings from the prod host vars as we
override the host vars entirely. Using a new hostname allows us to use a
different set of host vars with unique values reducing confusion.

Change-Id: I4b95bbe1bde29228164a66f2d3b648062423e294
---
 inventory/service/groups.yaml                               | 5 +++++
 playbooks/roles/letsencrypt-create-certs/handlers/main.yaml | 3 +++
 playbooks/zuul/run-base.yaml                                | 2 +-
 ...w02.opendev.org.yaml.j2 => review99.opendev.org.yaml.j2} | 4 ++--
 testinfra/test_gerrit.py                                    | 2 +-
 zuul.d/system-config-run.yaml                               | 6 +++---
 6 files changed, 15 insertions(+), 7 deletions(-)
 rename playbooks/zuul/templates/host_vars/{review02.opendev.org.yaml.j2 => review99.opendev.org.yaml.j2} (99%)

diff --git a/inventory/service/groups.yaml b/inventory/service/groups.yaml
index be39e25878..97703992e8 100644
--- a/inventory/service/groups.yaml
+++ b/inventory/service/groups.yaml
@@ -24,6 +24,11 @@ groups:
     - kdc03.openstack.org
     - eavesdrop01.opendev.org
     - paste01.opendev.org
+    # These are test specific hosts that we add to the backup
+    # group to mimic as much as possible what their prod version
+    # end up doing.
+    - gitea99.opendev.org
+    - review99.opendev.org
     # All these servers are "special-cased" in specifically
     # as they are puppet and should be replaced "soon"
     - ethercalc02.openstack.org
diff --git a/playbooks/roles/letsencrypt-create-certs/handlers/main.yaml b/playbooks/roles/letsencrypt-create-certs/handlers/main.yaml
index 601ebfa2c4..7a426fe2e3 100644
--- a/playbooks/roles/letsencrypt-create-certs/handlers/main.yaml
+++ b/playbooks/roles/letsencrypt-create-certs/handlers/main.yaml
@@ -255,6 +255,9 @@
 - name: letsencrypt updated ptg-opendev-org-main
   include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml
 
+- name: letsencrypt updated review99-opendev-org-main
+  include_tasks: roles/letsencrypt-create-certs/handlers/restart_apache.yaml
+
 # We split out handlers for each gitea host as handlers should be run in order
 # This allows us to do a rolling restart of the gitea backends.
 - name: letsencrypt updated gitea01-main
diff --git a/playbooks/zuul/run-base.yaml b/playbooks/zuul/run-base.yaml
index c2961db036..7830b9a0cc 100644
--- a/playbooks/zuul/run-base.yaml
+++ b/playbooks/zuul/run-base.yaml
@@ -86,7 +86,7 @@
         - host_vars/mirror-update01.opendev.org.yaml
         - host_vars/paste01.opendev.org.yaml
         - host_vars/refstack01.openstack.org.yaml
-        - host_vars/review02.opendev.org.yaml
+        - host_vars/review99.opendev.org.yaml
     - name: Display group membership
       command: ansible localhost -m debug -a 'var=groups'
     - name: Run base.yaml
diff --git a/playbooks/zuul/templates/host_vars/review02.opendev.org.yaml.j2 b/playbooks/zuul/templates/host_vars/review99.opendev.org.yaml.j2
similarity index 99%
rename from playbooks/zuul/templates/host_vars/review02.opendev.org.yaml.j2
rename to playbooks/zuul/templates/host_vars/review99.opendev.org.yaml.j2
index e6412d60ce..2b3ca486a6 100644
--- a/playbooks/zuul/templates/host_vars/review02.opendev.org.yaml.j2
+++ b/playbooks/zuul/templates/host_vars/review99.opendev.org.yaml.j2
@@ -111,7 +111,7 @@ gerrit_replication: []
 gerrit_serverid: a3593e8f-50c5-4336-a802-c2ffa22ba0fa
 gerrit_heap_limit: 6g
 letsencrypt_certs:
-  review02-opendev-org-main:
+  review99-opendev-org-main:
     - review.opendev.org
-    - review02.opendev.org
+    - review99.opendev.org
     - review.openstack.org
diff --git a/testinfra/test_gerrit.py b/testinfra/test_gerrit.py
index c824f7ea08..6dbab51e59 100644
--- a/testinfra/test_gerrit.py
+++ b/testinfra/test_gerrit.py
@@ -17,7 +17,7 @@ import time
 from util import take_screenshots
 
 testinfra_hosts = [
-    'review02.opendev.org',
+    'review99.opendev.org',
 ]
 
 
diff --git a/zuul.d/system-config-run.yaml b/zuul.d/system-config-run.yaml
index bb35fde50a..352cae46bb 100644
--- a/zuul.d/system-config-run.yaml
+++ b/zuul.d/system-config-run.yaml
@@ -852,7 +852,7 @@
       nodes:
         - name: bridge.openstack.org
           label: ubuntu-bionic
-        - name: review02.opendev.org
+        - name: review99.opendev.org
           label: ubuntu-focal
     required-projects:
       - openstack/project-config
@@ -863,7 +863,7 @@
         - playbooks/service-review.yaml
       run_test_playbook: playbooks/test-review.yaml
     host-vars:
-      review02.opendev.org:
+      review99.opendev.org:
         host_copy_output:
           '/home/gerrit2/review_site/etc': logs
           '/home/gerrit2/review_site/logs': logs
@@ -882,7 +882,7 @@
       - playbooks/roles/letsencrypt
       - playbooks/roles/gerrit/
       - playbooks/zuul/gerrit/
-      - playbooks/zuul/templates/host_vars/review02.opendev.org.yaml.j2
+      - playbooks/zuul/templates/host_vars/review99.opendev.org.yaml.j2
       - roles/bazelisk-build/
       - testinfra/test_gerrit.py
       - docker/gerrit/