Fix junit error, add HTML report

Specifying the family stops a deprecation warning being output.

Add a HTML report and report it as an artifact as well; this is easier
to read.

Change-Id: I2bd6505c19cee2d51e9af27e9344cfe2e1110572

playbooks/zuul/run-base.yaml

@@ -107,13 +107,23 @@
         content: "{{ testinfra_extra_data | default('') | to_nice_yaml(indent=2) }}"
         dest: '/home/zuul/testinfra_extra_data_fixture.yaml'
 
-    - name: Run testinfra to validate configuration
-      include_role:
-        name: tox
-      vars:
-        tox_envlist: testinfra
-        # This allows us to run from external projects (like testinfra
-        # itself)
-        tox_environment:
-          TESTINFRA_EXTRA_DATA: '/home/zuul/testinfra_extra_data_fixture.yaml'
-        zuul_work_dir: src/opendev.org/opendev/system-config
+    - name: Run and collect testinfra
+      block:
+        - name: Run testinfra to validate configuration
+          include_role:
+            name: tox
+          vars:
+            tox_envlist: testinfra
+            # This allows us to run from external projects (like testinfra
+            # itself)
+            tox_environment:
+              TESTINFRA_EXTRA_DATA: '/home/zuul/testinfra_extra_data_fixture.yaml'
+            zuul_work_dir: src/opendev.org/opendev/system-config
+      always:
+        - name: Return testinfra report artifact
+          zuul_return:
+            data:
+              zuul:
+                artifacts:
+                  - name: testinfra results
+                    url: "bridge.openstack.org/test-results.html"