diff --git a/modules/exim/manifests/init.pp b/modules/exim/manifests/init.pp index f5f11a53a7..244a59cc06 100644 --- a/modules/exim/manifests/init.pp +++ b/modules/exim/manifests/init.pp @@ -1,36 +1,46 @@ -class exim($sysadmin=[], $mailman_domains=[]) { +class exim( + $mailman_domains = [], + $sysadmin = [] +) { package { 'exim4-base': - ensure => present; - } - package { 'exim4-config': - ensure => present; - } - package { 'exim4-daemon-light': ensure => present, - require => [Package[exim4-base], Package[exim4-config]], + } + + package { 'exim4-config': + ensure => present, + } + + package { 'exim4-daemon-light': + ensure => present, + require => [ + Package[exim4-base], + Package[exim4-config] + ], } service { 'exim4': - ensure => running, - hasrestart => true, - subscribe => File['/etc/exim4/exim4.conf'], + ensure => running, + hasrestart => true, + subscribe => File['/etc/exim4/exim4.conf'], } file { '/etc/exim4/exim4.conf': - owner => 'root', - group => 'root', - mode => 444, - ensure => 'present', - content => template("exim/exim4.conf.erb"), - replace => 'true', + ensure => present, + content => template('exim/exim4.conf.erb'), + group => 'root', + mode => '0444', + owner => 'root', + replace => true, } file { '/etc/aliases': - owner => 'root', - group => 'root', - mode => 444, - ensure => 'present', - content => template("exim/aliases.erb"), - replace => 'true', + ensure => present, + content => template('exim/aliases.erb'), + group => 'root', + mode => '0444', + owner => 'root', + replace => true, } } + +# vim:sw=2:ts=2:expandtab:textwidth=79 diff --git a/modules/gerritbot/manifests/init.pp b/modules/gerritbot/manifests/init.pp index 84f86be9de..88ffa4347f 100644 --- a/modules/gerritbot/manifests/init.pp +++ b/modules/gerritbot/manifests/init.pp @@ -15,23 +15,24 @@ class gerritbot( } file { '/etc/init.d/gerritbot': - owner => 'root', + ensure => present, group => 'root', - mode => 555, - ensure => 'present', - source => 'puppet:///modules/gerritbot/gerritbot.init', + mode => '0555', + owner => 'root', require => Package['gerritbot'], + source => 'puppet:///modules/gerritbot/gerritbot.init', } service { 'gerritbot': - name => 'gerritbot', ensure => running, enable => true, hasrestart => true, require => File['/etc/init.d/gerritbot'], - subscribe => [Package['gerritbot'], - File['/etc/gerritbot/gerritbot.config'], - File['/etc/gerritbot/channel_config.yaml']], + subscribe => [ + Package['gerritbot'], + File['/etc/gerritbot/gerritbot.config'], + File['/etc/gerritbot/channel_config.yaml'] + ], } file { '/etc/gerritbot': @@ -40,39 +41,40 @@ class gerritbot( file { '/var/log/gerritbot': ensure => directory, - owner => 'root', group => 'gerrit2', - mode => 0775, + mode => '0775', + owner => 'root', } file { '/etc/gerritbot/channel_config.yaml': - owner => 'root', + ensure => present, group => 'gerrit2', - mode => 440, - ensure => 'present', - source => 'puppet:///modules/gerritbot/gerritbot_channel_config.yaml', + mode => '0440', + owner => 'root', replace => true, require => User['gerrit2'], + source => 'puppet:///modules/gerritbot/gerritbot_channel_config.yaml', } file { '/etc/gerritbot/logging.config': - owner => 'root', + ensure => present, group => 'gerrit2', - mode => 440, - ensure => 'present', - source => 'puppet:///modules/gerritbot/logging.config', + mode => '0440', + owner => 'root', replace => true, require => User['gerrit2'], + source => 'puppet:///modules/gerritbot/logging.config', } file { '/etc/gerritbot/gerritbot.config': - owner => 'root', - group => 'gerrit2', - mode => 440, - ensure => 'present', + ensure => present, content => template('gerritbot/gerritbot.config.erb'), - replace => 'true', + group => 'gerrit2', + mode => '0440', + owner => 'root', + replace => true, require => User['gerrit2'] } - } + +# vim:sw=2:ts=2:expandtab:textwidth=79 diff --git a/modules/launchpad_sync/manifests/init.pp b/modules/launchpad_sync/manifests/init.pp index 1b39105e89..b3287bc49b 100644 --- a/modules/launchpad_sync/manifests/init.pp +++ b/modules/launchpad_sync/manifests/init.pp @@ -1,37 +1,37 @@ class launchpad_sync( - $user='gerrit2', - $script_user='update', - $script_key_file='/home/gerrit2/.ssh/id_rsa', + $root_team, $script_logging_conf, $site, - $root_team + $script_key_file = '/home/gerrit2/.ssh/id_rsa', + $script_user = 'update', + $user = 'gerrit2' ) { - include mysql include mysql::python $packages = [ - "python-openid", # for launchpad sync script - "python-launchpadlib", # for launchpad sync script - ] + 'python-openid', # for launchpad sync script + 'python-launchpadlib', # for launchpad sync script + ] package { $packages: ensure => present, } file { '/usr/local/bin/update_gerrit_users.py': - owner => 'root', - group => 'root', - mode => 755, - source => "puppet:///modules/launchpad_sync/update_gerrit_users.py", - ensure => present, + ensure => present, + group => 'root', + mode => '0755', + owner => 'root', + source => 'puppet:///modules/launchpad_sync/update_gerrit_users.py', } - cron { "sync_launchpad_users": - user => $user, - minute => "*/15", + cron { 'sync_launchpad_users': + user => $user, + minute => '*/15', command => "sleep $((RANDOM\\%60+60)) && timeout -k 5m 8h python /usr/local/bin/update_gerrit_users.py ${script_user} ${script_key_file} ${site} ${root_team} ${script_logging_conf}", require => File['/usr/local/bin/update_gerrit_users.py'], } - } + +# vim:sw=2:ts=2:expandtab:textwidth=79