From db182ec0177b4c3e6af09f598028c84d5c8b5d52 Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Wed, 10 Nov 2021 06:50:49 +1100
Subject: [PATCH] gerrit: test reviewed flag add/delete/add cycle

A suggested follow-on to Ifaee5981e0977d7d1135275e7d8a0790075f670b

Change-Id: Ied549d90f9f8e336f1c6661d101480ed4d561b1b
---
 playbooks/test-review.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/playbooks/test-review.yaml b/playbooks/test-review.yaml
index a90dbdbf0f..97c291d917 100644
--- a/playbooks/test-review.yaml
+++ b/playbooks/test-review.yaml
@@ -252,13 +252,20 @@
         - 2
         - 3
 
+    # NOTE(ianw) we do an add/delete/add cycle as we've seen issues
+    # with duplicate updates causing problems before; e.g.
+    #  https://gerrit-review.googlesource.com/c/gerrit/+/312602
     - name: Post a file review to confirm accountPatchDb connection
       uri:
         url: 'http://localhost:8081/a/changes/y%2Ftestproject~1/revisions/1/files/file-1.txt/reviewed'
-        method: PUT
+        method: '{{ item[0] }}'
         user: admin
         password: secret
-        status_code: 201
+        status_code: '{{ item[1] }}'
+      loop:
+        - [ PUT, 201 ]
+        - [ DELETE, 204 ]
+        - [ PUT, 201 ]
 
     - name: Run selenium container
       include_role: