Disable Gerrit auto-abandon

With the advent of ACL-controlled abandon and restore capability in
more recent Gerrit releases, we can now put this power in the hands
of core reviewers for individual projects and should no longer need
to rely on hacky system-wide automated rules to abandon stale
changes.

Change-Id: I85c8ebc548df8328437615bca472eddd4fc0375f

modules/gerrit/manifests/cron.pp

@@ -1,17 +1,6 @@
 # == Class: gerrit::cron
 #
-class gerrit::cron(
-  $script_user = 'update',
-  $script_key_file = '/home/gerrit2/.ssh/id_rsa'
-) {
-
-  cron { 'expireoldreviews':
-    user    => 'gerrit2',
-    hour    => '6',
-    minute  => '3',
-    command => "python /usr/local/bin/expire-old-reviews ${script_user} ${script_key_file}",
-    require => Class['jeepyb'],
-  }
+class gerrit::cron {
 
   cron { 'gerrit_repack':
     user        => 'gerrit2',
@@ -22,6 +11,11 @@ class gerrit::cron(
     environment => 'PATH=/usr/bin:/bin:/usr/sbin:/sbin',
   }
 
+  cron { 'expireoldreviews':
+    ensure      => 'absent',
+    user        => 'gerrit2',
+  }
+
   cron { 'removedbdumps':
     ensure      => 'absent',
     user        => 'gerrit2',

modules/openstack_project/manifests/gerrit.pp

@@ -43,9 +43,6 @@ class openstack_project::gerrit (
   $contactstore_appsec = '',
   $contactstore_pubkey = '',
   $contactstore_url = '',
-  $script_user = 'update',
-  $script_key_file = '/home/gerrit2/.ssh/id_rsa',
-  $script_logging_conf = '/home/gerrit2/.sync_logging.conf',
   $projects_file = 'UNDEF',
   $projects_config = 'UNDEF',
   $github_username = '',
@@ -200,10 +197,7 @@ class openstack_project::gerrit (
   }
 
   if ($testmode == false) {
-    class { 'gerrit::cron':
-      script_user     => $script_user,
-      script_key_file => $script_key_file,
-    }
+    include gerrit::cron
     class { 'github':
       username         => $github_username,
       project_username => $github_project_username,

modules/openstack_project/manifests/review.pp

@@ -113,9 +113,6 @@ class openstack_project::review (
     contactstore_pubkey                 => $contactstore_pubkey,
     contactstore_url                    =>
       'http://www.openstack.org/verify/member/',
-    script_user                         => 'launchpadsync',
-    script_key_file                     => '/home/gerrit2/.ssh/launchpadsync_rsa',
-    script_logging_conf                 => '/home/gerrit2/.sync_logging.conf',
     projects_file                       =>
       'puppet:///modules/openstack_project/review.projects.yaml',
     projects_config                     =>

modules/openstack_project/manifests/review_dev.pp

@@ -48,9 +48,6 @@ class openstack_project::review_dev (
     contactstore_pubkey             => $contactstore_pubkey,
     contactstore_url                =>
       'https://review-dev.openstack.org/fakestore',
-    script_user                     => 'launchpadsync',
-    script_key_file                 => '/home/gerrit2/.ssh/launchpadsync_rsa',
-    script_logging_conf             => '/home/gerrit2/.sync_logging.conf',
     projects_file                   =>
       'puppet:///modules/openstack_project/review-dev.projects.yaml',
     projects_config                 =>