Set some parameters to more sensible defaults.

Also, moved depends for launchpad sync script to the launchpad sync
module, and put the ntp stuff into an ntp module.

Change-Id: I2568752493fefa305f9108a23da101d80a311552

modules/gerrit/manifests/cron.pp

@@ -1,6 +1,6 @@
 class gerrit::cron(
-    $script_user,
-    $script_key_file
+    $script_user='update',
+    $script_key_file='/home/gerrit2/.ssh/id_rsa'
     ) {
 
     cron { "expireoldreviews":

modules/gerrit/manifests/init.pp

@@ -53,8 +53,8 @@
 
 class gerrit($virtual_hostname=$fqdn,
       $canonicalweburl="https://$fqdn/",
-      $ssl_cert_file='',
-      $ssl_key_file='',
+      $ssl_cert_file='/etc/ssl/certs/ssl-cert-snakeoil.pem',
+      $ssl_key_file='/etc/ssl/private/ssl-cert-snakeoil.key',
       $ssl_chain_file='',
       $openidssourl="https://login.launchpad.net/+openid",
       $email='',
@@ -70,8 +70,6 @@ class gerrit($virtual_hostname=$fqdn,
       $httpd_maxwait='',
       $commentlinks = [],
       $war,
-      $script_user,
-      $script_key_file,
       $enable_melody = 'false',
       $melody_session = 'false',
       $mysql_password,