Literal $ characters in the template which are not part of a
substitution variable should be doubled to to avoid raising a
ValueError exception.
Change-Id: I14fd33571d63d50fc65e8c87fb10577e691b6c8e
The script that is run by find on each apply test file has -e set,
yet, it attempts to save the exit code from puppet apply and keep
running even in error. Remove -e so that it does not immediately
exit and can continue as designed.
Change-Id: I1a24e80f42be8d028ecc3eb02df54b49f811fff4
Otherwise, there is a case where the results are not rendered properly
because the shell exits.
Change-Id: Ica05615cad4fcc15c9d941d16f74cb4f68bc5a99
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This script closely follows the script in
openstack/puppet-openstack-integration to provide installation of
modules in both testing contexts: zuul and local development.
Change-Id: I517954d26409f2fbe96588f40f6f07316d85843d
Co-Authored-By: Colleen Murphy <colleen@gazlene.net>
Every repo should have a core group that includes infra-core, and
each of those core groups should be members of the infra-council.
Change-Id: Ibc02900cf2d885fa513a78b83b902dd0c4273e72
This tool will create or modify groups as specified on the command
line. It is useful for mass-updating a large number of groups.
In particular, setting the owner of an existing group is only
available in the REST API, rather than SSH.
Change-Id: I56762b16701ca96b45c8a626edca4cbc26e2859f
This makes it easier to tell which node definition is being evaluated
Because xargs -P doesn't do bash functions, some of the apply_test has
been moved into test_puppet_apply.sh. All the test snippets and test
output is being recorded in files in tools/opt, then catted for the
user.
Change-Id: I4fb77f93f9e9a7216b62634438a11d8d297bdefe
There's no need to create per-provider image update logs for
providers which only use diskimages of the same.
Change-Id: I06e5413ac9357587cd4aa7afa34414b0cc01c124
* tools/who-approves.py: New script which, when run using
OpenStack's Gerrit server, builds JSON and YAML representations of
repos with information on the official owning project if any,
integration status, and groups with approve rights listing the
members of each along with their Gerrit preferred E-mail addresses
and usernames when available.
It was done as a demonstration to a representative of a foundation
member company who requested a list of the "core reviewers" for
official projects, optionally broken down by integrated vs. other.
I'm attempting to show that this data is already publicly available
and can be extracted/analyzed by anyone without needing to request
it.
Change-Id: I017d98e2a45d5082fce8f4eecb5e6f8633c02ac8
Although this only needs to be done once, it's ugly enough of a task
that it should have a script, and that script should be reviewed.
The script can be run locally on a machine without a hieradata and it
will create a local directory with all of the keys and none of the data.
It will also print out the total mapping and a report on which keys are
duplicated across hosts after group de-duplication is taken in to
account.
Change-Id: Id0af46abb8f4167bd91e95cd7a6cd2e35e5b0a94
This is the second part of splitting out log files for image builds;
putting diskimage-builder logs into separate files. They are added
with a special "dib" provider to keep them grouped.
Change-Id: I6406f63df2f625beee57d7ff9707bd3b4f3fc060
The apply test does some really simple string manipulation to generate
puppet manifests based on our site.pp on the fly. Unfortunately the old
code assumed there would be no blank lines within a node{} definition.
This assumption is breaking as we work to decouple the
openstack_project::server contents from within openstack_project
manifests and move that into site.pp.
This is a relatively simple fix where we csplit nodes based on the
previous /^}$/ which ends the last node{} definition instead of
splitting on blank lines. Added some comments to make what the parsing
does a bit more clear.
Change-Id: I2cc7317ed90423d6f923c4303a76e091a0bc2ebb
Generate a logging configuration template for nodepool that splits
image-build logs out into separate files.
A tool to generate and maintain this file based on the nodepool
configuration is added.
The logging configuration template this tool creates is added
alongside the main configuration. This is passed to the deployment
puppet module via a parameter.
Change-Id: I4723c68e5c83b536560e0a8bd7b73e312b46fc02
Depends-on: Iec77fb62c353d09186140b23912caf02225a643b
Changes to the projects.yaml (nee programs.yaml) in the
openstack/governance repo to accommodate big tent terminology have
resulted in a need to similarly adjust the script interpreting it.
While at it, update the variable names within the script for
clarity.
Change-Id: Ie001901c33749aa41181a09e43576bf9d516b4e5
This reverts commit 3b563fb59e7dfb233d4d0a07117499ac04f4a6ce.
Do not approve until Ief6c8e9bf7d71ddc63dba484390124546f14b93a is
applied to new nodepool images.
Change-Id: Ia7422d4f8fe316cc37c1310def0e7a9e2f232d35
Make /etc/puppet/environments/production/environment.conf so that
the apply test will find a default directory environment.
Change-Id: I062949d6c23545c40690edc39302095b0dec3c84
This causes apply-test.sh to get the list of puppet modules to do
integration test with from modules.env. Modules.env has been
refactored to have three lists of modules: Package modules(MODULES),
SOURCE_MODULES, and INTEGRATION_MODULES.
When PUPPET_INTEGRATION_TEST is not set, INTEGRATION_MODULES is
folded into SOURCE_MODULES.
In apply-test.sh, INTEGRATION_MODULES is sourced from modules.env
and some string/array manipulation is performed to pass each entry
to zuul-cloner.
Change-Id: I47302c5c7e8c41b985f16a05c4e9b8078ea867a3
--color=false remove ansi escapes
cping /etc/hiera.yaml /etc/puppet/hiera.yaml shuts up puppet
complaining that it doesn't have hiera.yaml to read
Change-Id: Iea7222c66f2fcc1338bc7baffb572d1a1ab2ecd6
Part of an effort to split most of puppet modules out of system-config.
https://review.openstack.org/#/c/130619/ should land before this
commit can be merged.
Change-Id: I7720ad7d2b25816c63e971112a7a733bde52b7f3
We are renaming openstack-infra/config to
openstack-infra/system-config. This patch addresses the one file
in the tools directory that needed editing.
Change-Id: Id078dc7031f833c6d1a58cddbcecf0666244c6a1