{ "comments": [ { "unresolved": false, "key": { "uuid": "17e6ae19_3ddc821f", "filename": "/PATCHSET_LEVEL", "patchSetId": 16 }, "lineNbr": 0, "author": { "id": 12898 }, "writtenOn": "2024-04-30T23:46:36Z", "side": 1, "message": "Looks good to me.", "revId": "b2607979ab25ceaf1353c34149cec9e35af57329", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "ba72b8c6_8efe73fd", "filename": "docker/etherpad/Dockerfile", "patchSetId": 16 }, "lineNbr": 173, "author": { "id": 5263 }, "writtenOn": "2024-04-30T19:09:05Z", "side": 1, "message": "We should probably chmod this 0600 as well, but can do it in a separate change. The file already contains the password to the database backend, so these loose perms aren\u0027t a regression, just something we need to fix at some point. Same probably goes for the old APIKEY.txt file inside the container (just looked out of curiosity).", "revId": "b2607979ab25ceaf1353c34149cec9e35af57329", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ], "submitRequirementResults": [ { "submitRequirement": { "name": "Code-Review", "description": { "value": "Code reviewed by core reviewer" }, "applicabilityExpression": {}, "submittabilityExpression": { "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN" }, "overrideExpression": {}, "allowOverrideInChildProjects": true }, "applicabilityExpressionResult": {}, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]} }, "overrideExpressionResult": {}, "patchSetCommitId": "b2607979ab25ceaf1353c34149cec9e35af57329", "legacy": { "value": false }, "forced": {}, "hidden": {} }, { "submitRequirement": { "name": "Verified", "description": { "value": "Verified in gate by CI" }, "applicabilityExpression": {}, "submittabilityExpression": { "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN" }, "overrideExpression": {}, "allowOverrideInChildProjects": false }, "applicabilityExpressionResult": {}, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]} }, "overrideExpressionResult": {}, "patchSetCommitId": "b2607979ab25ceaf1353c34149cec9e35af57329", "legacy": { "value": false }, "forced": {}, "hidden": {} }, { "submitRequirement": { "name": "Workflow", "description": { "value": "Approved for gate by core reviewer" }, "applicabilityExpression": {}, "submittabilityExpression": { "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN" }, "overrideExpression": {}, "allowOverrideInChildProjects": false }, "applicabilityExpressionResult": {}, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]} }, "overrideExpressionResult": {}, "patchSetCommitId": "b2607979ab25ceaf1353c34149cec9e35af57329", "legacy": { "value": false }, "forced": {}, "hidden": {} } ] }