Clark Boylan ef450d1bce Update to Gitea 1.20
The 1.20 release is here. Upgrade to this version.

Things we change:
 * Nodejs is updated to v20 to match the alpine 3.18 package version
   that gitea switched to.
 * Templates are updated to match upstream 1.20 templates.
 * We drop the deprecated LFS_CONTENT_PATH from our server config and
   add an equivalent [lfs] config section.
 * Normalize app.ini content so that gitea won't write it back out to
   disk which fails due to permissions (and we don't want it overriding
   our configs anyway). For this we need to add WORK_PATH,
   oauth2.JWT_SECRET, and normliazing spacing and quoting for entries.
 * Set JWT_SIGNING_PRIVATE_KEY_FILE explicitly to be located at
   /data/gitea/jwt/private.pem otherwise gitea attempts to create the
   jwt/ directory somewhere it doesn't have permissions to (I think /)
   and won't be persisted across containers.
 * Replace log.ENABLE_ACCESS_LOG with log.logger.access.MODE = file as
   log.ENABLE_ACCESS_LOG is deprecated and doesn't appear to work
   anymore. This appears to be a documentation issue or they deprecated
   and removed things more quickly than originaly anticipated.
 * Add log.ACCESS_LOG_TEMPLATE to readd source port info to the access
 * Add a templates/custom/header.tmpl file to set theme-color as the
   config item for this has been removed.

The 1.20.0 changelog [0] lists a number of breaking changes. I have
tried to capture there here as well as potential impacts to us:

 * Fix WORK_DIR for docker (root) image (#25738) (#25811)
   * We set APP_DATA_PATH to /data/gitea in our app.ini config which
     means we aren't relying on the inferred value from WORK_DIR. I
     think this isolates us from this chnage. But we can check for any
     content in /app/gitea on our running containers to be sure.
     Note we hardcode WORK_PATH to /data/gitea because gitea attempts to
     write this back to our config file otherwise as a result of this
 * Restrict [actions].DEFAULT_ACTIONS_URL to only github or self (#25581) (#25604)
   * We disable actions. This shouldn't affect us.
 * Refactor path & config system (#25330) (#25416)
   * This is related to the first breaking changes. Basically we need
     to check our use of WORK_PATH and determine if we need to hardcode
     it to something. Probably a good idea given how they keep changing
     this on us...
 * Fix all possible setting error related storages and added some tests (#23911) (#25244)
   * We don't use storage configs. This shouldn't affect us.
 * Use a separate admin page to show global stats, remove actions stat (#25062)
   * The breaking change only affects the use of Prometheus which we
     don't have yet.
 * Remove the service worker (#25010)
   * Is listed as a breaking change for UI cleanup that we don't need to
     cleanup. (ui.USE_SERVICE_WORKER can be removed).
 * Remove meta tags theme-color and default-theme (#24960)
   * Addressed by adding a custome templates/custom/header.tmpl file
     that sets this meta tag to the existing value. Note this only
     affects mobile clients so needs to be double checked via a mobile
 * Use [git.config] for reflog cleaning up (#24958)
   * Affects git.reflog config entries and we don' thave any.
 * Allow all URL schemes in Markdown links by default (#24805)
   * TODO determine if we need to limit link types and add that
     change if so. A point release was made to exclude bad types
     already. Not sure if there are others we need to add.
 * Redesign Scoped Access Tokens (#24767)
   * This breaks scoped tokens with scopes that don't exist anymore.
     I don't think we use scoped tokens.
 * Fix team members API endpoint pagination (#24754)
   * They 1 index the pagination of this endpoint now instead of 0
     indexing it.
 * Rewrite logger system (#24726)
   * They made changes to the loggers and encourage people to check
     their logs work as expected when upgrading. Using our test instance
     logs I don't see anything that is a problem.
 * Increase default LFS auth timeout from 20m to 24h (#24628)
   * We don't LFS but can change the timeout if necssary.
 * Rewrite queue (#24505)
   * Check for 'Removed queue option:' log entries and clean up
     corresponding entries in app.ini. We don't have any of these
     entries in our logs.
 * Remove unused setting time.FORMAT (#24430)
   * We didn't have this entry in app.ini.
 * Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING (#24270)
   * This setting can be removed from app.ini, but we don't set it.
 * Correct the access log format (#24085)
   * We uncorrect it because they removed source port info in the
     correction step. They did this because some log parsers don't
     understand having the port info present, but if you are behind a
     reverse proxy this information is very important. We run gitea behind
     a reverse proxy.
 * Reserve ".png" suffix for user/org names (#23992)
   * .png is no longer a valid user/org name (it didn't work before
 * Prefer native parser for SSH public key parsing (#23798)
   * If you relied on the openssh ssh-keygen executable for public key
     parsing then you must explicitly set config to use it. I don't
     think we do as the golang native parser should handle the keytypes
     we use.
 * Editor preview support for external renderers (#23333)
   * This removed an app.ini settings we don't seem to set.
 * Add Gitea Profile Readmes (#23260)
   * Readmes in .profile repositories will always be shown now. We don't
     have .profiles repos so this doesn't affect us.
 * Refactor ctx in templates (#23105)
   * This affects custom templates as we may need to replace ctx with
     ctxData in our templates.
   * I've searched our templates for 'root', 'ctx', and 'ctxData' and
     have found no instances. Looking at the files modifying by the
     commits related to this change:
     we don't seem to override the affected files. I think we are fine
     as is.

The 1.20.1 changelog indicates there are no breaking changes, and git
diff shows no changes to the templates between 1.20.0 and 1.20.1.

The 1.20.2 changelog indicates there are no breaking changes, and git
diff shows no changes to the templates between 1.20.1 and 1.20.2.

The 1.20.3 changelog indicates there is a single breaking change:
 * Fix the wrong derive path (#26271) (#26318)
   * If I'm reading the code correctly, I think the problem was storage
     configuration inheriting the base storage config and particularly
     the related path. Then when archival storage looked for its config
     the path was the root gitea storage path and it would inadverdently
     delete all repos when deleting a single repo or something like
     that. We don't use these features and these are mirrors anyway so I
     don't think this really affects us.


Change-Id: I265f0ad16c0e757a11c1d889996ffe2198625a1a
2023-08-21 08:49:46 -07:00
adns-primary.yaml.j2 dns: move tsig_key into common group variable 2023-04-13 11:38:01 +10:00
adns.yaml.j2 dns: move tsig_key into common group variable 2023-04-13 11:38:01 +10:00
afs-client.yaml.j2 afs-client: move reduced cache to group variable 2019-12-16 15:34:12 +11:00
all.yaml.j2 Block outbound SMTP connections from test jobs 2021-12-09 18:46:38 +00:00
bastion.yaml.j2 launch: Automatically do RAX rdns updates when launching nodes 2022-12-01 11:26:32 +11:00
control-plane-clouds.yaml.j2 Final cleanup of internap/inap/iweb references 2023-02-13 23:56:22 +00:00
eavesdrop.yaml.j2 statusbot: add mastodon config options 2022-11-16 11:02:07 +11:00
gitea-lb.yaml.j2 gitea-lb: test ssl connections during testing too 2022-07-07 10:02:46 +10:00
gitea.yaml.j2 Update to Gitea 1.20 2023-08-21 08:49:46 -07:00
jvb.yaml.j2 Update colibri for all the JVBs 2022-09-16 12:10:00 -07:00
kerberos-kdc.yaml.j2 kerberos-kdc: role to manage Kerberos KDC servers 2021-03-17 08:30:52 +11:00
keycloak.yaml.j2 Add a keycloak server 2021-12-03 14:17:23 -08:00
letsencrypt.yaml.j2 letsencrypt : don't use staging in the gate 2021-10-06 15:34:21 +11:00
mailman.yaml.j2 mailman: add variable for matching UAs in Apache 2023-01-11 15:47:20 +11:00
meetpad.yaml.j2 Update colibri for all the JVBs 2022-09-16 12:10:00 -07:00
nodepool.yaml.j2 Finish cleaning up packethost references 2023-02-13 23:56:21 +00:00
refstack.yaml.j2 Rename refstack group variables 2021-03-19 16:01:46 +11:00
registry.yaml.j2 Update registry testing to use LE 2020-01-14 13:50:13 -08:00
zuul-executor.yaml.j2 Add zuul keystore password 2021-04-12 14:58:07 -07:00
zuul-lb.yaml.j2 zuul-lb : issue HEAD / checks 2022-03-08 10:24:03 +11:00
zuul-merger.yaml.j2 Run Zuul using Ansible and Containers 2020-04-24 09:18:44 -05:00
zuul-scheduler.yaml.j2 Remove gearman from Zuul 2022-02-01 13:52:47 -08:00
zuul-web.yaml.j2 Run Zuul using Ansible and Containers 2020-04-24 09:18:44 -05:00
zuul.yaml.j2 Remove gearman from Zuul 2022-02-01 13:52:47 -08:00