3fa3be7ede
Add a check job to require upstream URLs to use a scheme that we are confident won't cause connection errors during the import. Add a tox configuration for this new job, as well as the existing alphabetical check script, to make it easier for developers to run those tests locally just by running "tox". Change-Id: I894ac0f8afb234404bb6e80e64b90aa25e052f10
46 lines
1.0 KiB
Python
Executable File
46 lines
1.0 KiB
Python
Executable File
#!/usr/bin/env python
|
|
"""
|
|
Allow git:// and https:// URLs for importing upstream repositories,
|
|
but not git@
|
|
"""
|
|
|
|
import argparse
|
|
|
|
import yaml
|
|
|
|
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument('-v', '--verbose',
|
|
dest='verbose',
|
|
default=False,
|
|
action='store_true',
|
|
)
|
|
parser.add_argument(
|
|
'infile',
|
|
help='path to review.projects.yaml',
|
|
)
|
|
args = parser.parse_args()
|
|
|
|
projects = yaml.load(open(args.infile, 'r'))
|
|
|
|
VALID_SCHEMES = ['https://', 'http://', 'git://']
|
|
|
|
for p in projects:
|
|
name = p.get('project')
|
|
if not name:
|
|
# not a project
|
|
continue
|
|
upstream = p.get('upstream')
|
|
if args.verbose:
|
|
print 'Checking %s: %r' % (name, upstream)
|
|
if not upstream:
|
|
continue
|
|
for prefix in VALID_SCHEMES:
|
|
if upstream.startswith(prefix):
|
|
break
|
|
else:
|
|
raise ValueError(
|
|
'Upstream URLs should use a scheme in %s, found %s' %
|
|
(VALID_SCHEMES, p['project'])
|
|
)
|