183e186fe0
The previous code had attempted to handle the case where the container
isn't running and we exec a zuul graceful stop in the container.
Unfortunately I got the string to check for wrong. I think I must've
checked the `docker exec` output and not the `docker-compose exec`
output.
This change updates the string to match exactly what ansible complained
about:
TASK [zuul-merger : Gracefully stop Zuul Merger] *******************************
fatal: [zm05.opendev.org]: FAILED! => {
"changed": true,
"cmd": "docker-compose exec merger zuul-merger stop",
"delta": "0:00:00.573561",
"end": "2022-09-14 01:59:41.721044",
"failed_when_result": true,
"rc": 1,
"start": "2022-09-14 01:59:41.147483"
}
STDERR:
No container found for merger_1
MSG:
non-zero return code
Specifically we check for 'No container found' in stderr.
Change-Id: I737b9da14c210215926804816d1e032540d694dc
43 lines
1.5 KiB
YAML
43 lines
1.5 KiB
YAML
- name: Check if Zuul merger containers are running
|
|
# It is possible they are stopped due to some external circumstance.
|
|
# NOTE: docker-compose ps -q reports exited containers unlike docker ps -q
|
|
command:
|
|
cmd: docker-compose ps -q
|
|
chdir: /etc/zuul-merger
|
|
become: true
|
|
become_user: root
|
|
register: merger_container_list
|
|
- name: Gracefully stop Zuul Merger
|
|
shell:
|
|
cmd: docker-compose exec merger zuul-merger stop
|
|
chdir: /etc/zuul-merger
|
|
become: true
|
|
become_user: root
|
|
# Only run the docker exec command if a container is running
|
|
when: merger_container_list.stdout_lines | length > 0
|
|
register: zm_graceful
|
|
failed_when:
|
|
- zm_graceful.rc != 0
|
|
# There is a fun race with docker exec and shutting down the
|
|
# container running the exec. If the container is stopped while
|
|
# the exec is running then the command in the exec effectively gets
|
|
# kill -9'd and the docker exec command rc is 137. Since this
|
|
# should only happen when the container is stopped we proceed with
|
|
# the overall graceful shutdown.
|
|
- zm_graceful.rc != 137
|
|
# If the exec fails because the container is not running we continue.
|
|
- "'No container found' not in zm_graceful.stderr"
|
|
- name: Wait for Zuul Merger to stop
|
|
shell:
|
|
cmd: docker-compose ps -q | xargs docker wait
|
|
chdir: /etc/zuul-merger
|
|
become: true
|
|
become_user: root
|
|
when: merger_container_list.stdout_lines | length > 0
|
|
- name: Down Zuul Merger containers
|
|
shell:
|
|
cmd: docker-compose down
|
|
chdir: /etc/zuul-merger
|
|
become: true
|
|
become_user: root
|