From 35032db01768211abac37af477867f147204d101 Mon Sep 17 00:00:00 2001 From: Gerrit User 7160 <7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Sat, 15 Oct 2022 21:52:43 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review-1 (5 comments) Patch-set: 2 Reviewer: Gerrit User 7160 <7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 30025 \u003c30025@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_7160\u003e replied on the change"} --- b18cd2fa852f2630aaf041608dbac74ff8e9e2b8 | 111 +++++++++++++++++++++++ 1 file changed, 111 insertions(+) diff --git a/b18cd2fa852f2630aaf041608dbac74ff8e9e2b8 b/b18cd2fa852f2630aaf041608dbac74ff8e9e2b8 index 4ae8d97b..27ec666c 100644 --- a/b18cd2fa852f2630aaf041608dbac74ff8e9e2b8 +++ b/b18cd2fa852f2630aaf041608dbac74ff8e9e2b8 @@ -17,6 +17,46 @@ "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "67ea63ee_3eb8f616", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 7160 + }, + "writtenOn": "2022-10-15T21:52:43Z", + "side": 1, + "message": "Need to fix .next to be consistent for 2022.11,\nwhoch will be the first releases for key_manager and load_balancer.", + "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "31ba94a8_3710d872", + "filename": "add-ons/guidelines/key_manager.next.json", + "patchSetId": 2 + }, + "lineNbr": 58, + "author": { + "id": 7160 + }, + "writtenOn": "2022-10-15T21:52:43Z", + "side": 1, + "message": "I though that 2022.11 will be the first release of key_manager.\nSO this is the next one targeted for 2023.06?", + "range": { + "startLine": 58, + "startChar": 38, + "endLine": 58, + "endChar": 45 + }, + "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -40,6 +80,30 @@ "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "7b9b6eec_5be6b009", + "filename": "add-ons/guidelines/key_manager.next.json", + "patchSetId": 2 + }, + "lineNbr": 59, + "author": { + "id": 7160 + }, + "writtenOn": "2022-10-15T21:52:43Z", + "side": 1, + "message": "Agree with Vida. The first release should be 2022.11 and 2023.06 will replace it.", + "parentUuid": "aaca067e_2e461b92", + "range": { + "startLine": 59, + "startChar": 17, + "endLine": 59, + "endChar": 21 + }, + "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -62,6 +126,53 @@ }, "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "c19bbe5f_65867633", + "filename": "add-ons/guidelines/load_balancer.next.json", + "patchSetId": 2 + }, + "lineNbr": 59, + "author": { + "id": 7160 + }, + "writtenOn": "2022-10-15T21:52:43Z", + "side": 1, + "message": "Agree. Ditto", + "parentUuid": "94f9a503_0424a98d", + "range": { + "startLine": 59, + "startChar": 6, + "endLine": 59, + "endChar": 21 + }, + "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "7c8abc03_ed6f86ee", + "filename": "add-ons/guidelines/orchestration.next.json", + "patchSetId": 2 + }, + "lineNbr": 58, + "author": { + "id": 7160 + }, + "writtenOn": "2022-10-15T21:52:43Z", + "side": 1, + "message": "We need to be consistent.\nI think we should do 2022.11 as curernt .next.jon for all projects, including orchestartion and key_management, barbican as well as core.\nANd only after we promote 2022.11 we move all Nexts to 2023.06.", + "range": { + "startLine": 58, + "startChar": 0, + "endLine": 58, + "endChar": 49 + }, + "revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file