From aff9e5fbd50fa2476ae3be69380488a2174c3304 Mon Sep 17 00:00:00 2001 From: smarcet Date: Sat, 16 Nov 2019 14:48:24 -0300 Subject: [PATCH] Fixed Track Tag Group Update method Change-Id: I3c94c47034e378d10964106e42c68dfe129e9519 --- .../Summit/OAuth2SummitTrackTagGroupsApiController.php | 7 ++++++- app/Services/Model/SummitTrackTagGroupService.php | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitTrackTagGroupsApiController.php b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitTrackTagGroupsApiController.php index 7912d3b4..f0247799 100644 --- a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitTrackTagGroupsApiController.php +++ b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitTrackTagGroupsApiController.php @@ -260,7 +260,12 @@ final class OAuth2SummitTrackTagGroupsApiController extends OAuth2ProtectedContr if(!Request::isJson()) return $this->error400(); $data = Input::json(); - $summit = SummitFinderStrategyFactory::build($this->summit_repository, $this->resource_server_context)->find($summit_id); + $summit = SummitFinderStrategyFactory::build + ( + $this->summit_repository, + $this->resource_server_context + )->find($summit_id); + if (is_null($summit)) return $this->error404(); $rules = [ diff --git a/app/Services/Model/SummitTrackTagGroupService.php b/app/Services/Model/SummitTrackTagGroupService.php index 1c4e0534..38253f69 100644 --- a/app/Services/Model/SummitTrackTagGroupService.php +++ b/app/Services/Model/SummitTrackTagGroupService.php @@ -177,6 +177,8 @@ implements ISummitTrackTagGroupService } } + $track_tag_group = TrackTagGroupFactory::populate($track_tag_group, $summit, $data); + if (isset($data['order']) && intval($data['order']) != $track_tag_group->getOrder()) { // request to update order $summit->recalculateTrackTagGroupOrder($track_tag_group, intval($data['order']));