openinfra
/
python-tempestconf
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 30742 \u003c30742@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Soniya Murlidhar Vyas replied on the change"}
Attention: {"person_ident":"Gerrit User 8449 \u003c8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Soniya Murlidhar Vyas replied on the change"}
This commit is contained in:
Gerrit User 30742 2022-01-10 12:48:07 +00:00 committed by Gerrit Code Review
parent 8e7c6704f9
commit 0676dee387
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
b284f4f7b7dfdce06054bdb546956d9c11832e32
View File

@ -69,6 +69,24 @@
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d71348cf_9dc0c206",
"filename": "config_tempest/services/image.py",
"patchSetId": 3
},
"lineNbr": 69,
"author": {
"id": 30742
},
"writtenOn": "2022-01-10T12:48:07Z",
"side": 1,
"message": "Ack",
"parentUuid": "b6050ed7_5c2e0b81",
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -92,6 +110,30 @@
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2efad8d4_cdc04f61",
"filename": "config_tempest/services/image.py",
"patchSetId": 3
},
"lineNbr": 87,
"author": {
"id": 30742
},
"writtenOn": "2022-01-10T12:48:07Z",
"side": 1,
"message": "IMO, we don\u0027t need to worry about \u0027stores\u0027 value being null or 0 since we want to check weather this value is greater than 1. If it is 1 or less than 1 i.e 0 or null we won\u0027t enable the multi-store feature.",
"parentUuid": "00abe89a_063e4e9e",
"range": {
"startLine": 87,
"startChar": 12,
"endLine": 87,
"endChar": 18
},
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -114,6 +156,30 @@
},
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "df9e489d_94bbe613",
"filename": "config_tempest/services/image.py",
"patchSetId": 3
},
"lineNbr": 90,
"author": {
"id": 30742
},
"writtenOn": "2022-01-10T12:48:07Z",
"side": 1,
"message": "Ack",
"parentUuid": "f2a20faf_dab856f8",
"range": {
"startLine": 90,
"startChar": 0,
"endLine": 90,
"endChar": 3
},
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}