openinfra
/
python-tempestconf
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 22873 \u003c22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Martin Kopec replied on the change"}
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Martin Kopec replied on the change"}
This commit is contained in:
Gerrit User 22873 2022-03-29 16:25:04 +00:00 committed by Gerrit Code Review
parent b769a6593b
commit 08ffd646dc
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
6bb29fdd274f70eb4a9bf32fc8813368eedb8af4
View File

@ -17,6 +17,24 @@
"revId": "6bb29fdd274f70eb4a9bf32fc8813368eedb8af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d6170d7c_d8966c5c",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 11,
"author": {
"id": 22873
},
"writtenOn": "2022-03-29T16:25:04Z",
"side": 1,
"message": "no, it didn\u0027t happen, because the body of the if statement wasn\u0027t executed .. assert expecting the call failed",
"parentUuid": "b87e8a4b_2755d399",
"revId": "6bb29fdd274f70eb4a9bf32fc8813368eedb8af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "I\u0027d say \"result in makedirs always passing, whether\"... (it\u0027s always called)",
"revId": "6bb29fdd274f70eb4a9bf32fc8813368eedb8af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3b7628a9_1b520e44",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 22873
},
"writtenOn": "2022-03-29T16:25:04Z",
"side": 1,
"message": "Done",
"parentUuid": "1baff4d4_25dd228c",
"revId": "6bb29fdd274f70eb4a9bf32fc8813368eedb8af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}