Browse Source

Update patch set 10

Patch Set 10: Code-Review+1

(3 comments)

Patch-set: 10
Reviewer: Gerrit User 22873 <22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 22873 \u003c22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Martin Kopec replied on the change"}
Attention: {"person_ident":"Gerrit User 30742 \u003c30742@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Martin Kopec replied on the change"}
changes/69/820169/meta
Gerrit User 22873 4 months ago committed by Gerrit Code Review
parent
commit
0b17071c9c
  1. 63
      3246f65d9de427b2e146d99d4044aea9bf0a0dff

63
3246f65d9de427b2e146d99d4044aea9bf0a0dff

@ -33,6 +33,69 @@
"message": "\u003e Patch Set 10: Code-Review-1\n\u003e \n\u003e Need the testproject to test if tempestconf will set properly the multistore, and also add a unittest\n\n@arxcruz, In the commit message I have mentioned the two testprojects exercising both the configs, please do have a look!!\nI will do a fresh review for the unittest since this patch is pending for too long.",
"revId": "3246f65d9de427b2e146d99d4044aea9bf0a0dff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "781431a7_bdb3e30e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 22873
},
"writtenOn": "2022-01-19T12:48:26Z",
"side": 1,
"message": "check experimental ",
"revId": "3246f65d9de427b2e146d99d4044aea9bf0a0dff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "10c61729_ec1de562",
"filename": "config_tempest/services/image.py",
"patchSetId": 10
},
"lineNbr": 61,
"author": {
"id": 22873
},
"writtenOn": "2022-01-19T12:48:26Z",
"side": 1,
"message": "as Arx mentioned, the _get_number_of_stores returns a number, so let\u0027s edit this if to num_stores \u003e 0",
"range": {
"startLine": 61,
"startChar": 11,
"endLine": 61,
"endChar": 21
},
"revId": "3246f65d9de427b2e146d99d4044aea9bf0a0dff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "284934d9_c5877132",
"filename": "config_tempest/services/image.py",
"patchSetId": 10
},
"lineNbr": 85,
"author": {
"id": 22873
},
"writtenOn": "2022-01-19T12:48:26Z",
"side": 1,
"message": "better to use 0 , to have the type consistent - the method returns a number",
"range": {
"startLine": 85,
"startChar": 17,
"endLine": 85,
"endChar": 21
},
"revId": "3246f65d9de427b2e146d99d4044aea9bf0a0dff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
Loading…
Cancel
Save