openinfra
/
python-tempestconf
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10459\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 30674 \u003c30674@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10459\u003e replied on the change"}
This commit is contained in:
Gerrit User 10459 2023-09-15 08:59:55 +00:00 committed by Gerrit Code Review
parent 0c8379a98d
commit 0cfee4a072
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
834afdd6b1440d3696dcc27c9c3de04a1620ea01
View File

@ -105,6 +105,30 @@
"revId": "834afdd6b1440d3696dcc27c9c3de04a1620ea01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1d67bead_f947ac32",
"filename": "config_tempest/users.py",
"patchSetId": 2
},
"lineNbr": 51,
"author": {
"id": 10459
},
"writtenOn": "2023-09-15T08:59:55Z",
"side": 1,
"message": "roles_list is not so long O.o and it would be definitely more clear",
"parentUuid": "6e4fbe14_6e13c04f",
"range": {
"startLine": 51,
"startChar": 46,
"endLine": 51,
"endChar": 49
},
"revId": "834afdd6b1440d3696dcc27c9c3de04a1620ea01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -176,6 +200,30 @@
"revId": "834afdd6b1440d3696dcc27c9c3de04a1620ea01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "660624a0_c1ae4a17",
"filename": "config_tempest/users.py",
"patchSetId": 2
},
"lineNbr": 74,
"author": {
"id": 10459
},
"writtenOn": "2023-09-15T08:59:55Z",
"side": 1,
"message": "A note in the docstring wouldn\u0027t hurt",
"parentUuid": "4f01f366_c4623f09",
"range": {
"startLine": 74,
"startChar": 0,
"endLine": 74,
"endChar": 1
},
"revId": "834afdd6b1440d3696dcc27c9c3de04a1620ea01",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {