Browse Source

Update patch set 7

Patch Set 7:

(1 comment)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Abhishek Kekane replied on the change"}
changes/69/820169/meta
Gerrit User 9303 4 months ago committed by Gerrit Code Review
parent
commit
2a809e0dfa
  1. 27
      1bd900a36c502787b3499a7f0ab5672962dfc97b

27
1bd900a36c502787b3499a7f0ab5672962dfc97b

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "2bc46b2a_30ce78c1",
"filename": "config_tempest/services/image.py",
"patchSetId": 7
},
"lineNbr": 89,
"author": {
"id": 9303
},
"writtenOn": "2022-01-11T06:36:36Z",
"side": 1,
"message": "I think you should catch generic exception here, because actual glance API is raising NotFound if multiple stores are not configured, also a work is going on to check policy rule which will raise forbidden to restrict users from accessing the information.\n\nI think this should be like;\nstores \u003d None\ntry:\n stores \u003d self.client.info_stores()[\u0027stores\u0027]\nexcept Exception:\n C.LOG.info(\u0027Can not retrieve stores, either multiple stores are not configured or user are not allowed access stores information\u0027)\n return stores\n\nreturn len(stores)",
"range": {
"startLine": 85,
"startChar": 8,
"endLine": 89,
"endChar": 71
},
"revId": "1bd900a36c502787b3499a7f0ab5672962dfc97b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
Loading…
Cancel
Save