Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 22873 \u003c22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Luigi Toscano replied on the change"}
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Luigi Toscano replied on the change"}
This commit is contained in:
Gerrit User 10459 2022-03-29 13:13:28 +00:00 committed by Gerrit Code Review
parent f10e660e30
commit 46f7b4f6d0
2 changed files with 56 additions and 0 deletions

View File

@ -140,6 +140,24 @@
"parentUuid": "67511a47_358ed329",
"revId": "5ffde61b69cf79547c9cd1da731b62d99da0c762",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "18d3cf34_8c82d597",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 10459
},
"writtenOn": "2022-03-29T13:13:28Z",
"side": 1,
"message": "And the code was first created when makedirs didn\u0027t accept exist_ok (when we had to support python 2.7).",
"parentUuid": "72e74477_e8e0bffa",
"revId": "5ffde61b69cf79547c9cd1da731b62d99da0c762",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "b87e8a4b_2755d399",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 11,
"author": {
"id": 10459
},
"writtenOn": "2022-03-29T13:13:28Z",
"side": 1,
"message": "\"to makedirs which failed\": the call happened, but it failed",
"revId": "6bb29fdd274f70eb4a9bf32fc8813368eedb8af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1baff4d4_25dd228c",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 10459
},
"writtenOn": "2022-03-29T13:13:28Z",
"side": 1,
"message": "I\u0027d say \"result in makedirs always passing, whether\"... (it\u0027s always called)",
"revId": "6bb29fdd274f70eb4a9bf32fc8813368eedb8af4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}