Update patch set 2
Patch Set 2: Code-Review+1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 32363 <32363@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, 1426074ef0077fe1cc0465f59f865c21b03359d9 Attention: {"person_ident":"Gerrit User 35007 \u003c35007@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32363\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 32363 \u003c32363@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32363\u003e replied on the change"}
This commit is contained in:
parent
3092b9875e
commit
48ef412f87
|
@ -16,6 +16,23 @@
|
||||||
"message": "Hi Martin,\n\nIn our cloud, we\u0027ve configured our endpoints to have path based suffixes (e.g. `http://IP:PORT/\u003csome_path\u003e/v2`), and the discovery tool isn\u0027t working properly with this kind of endpoints because it cuts too much (`\u003csome_path\u003e/v2` this is example) when the port is **not** None. I tried to work around this by using `utils.get_base_url` instead of `no_port_cut_url` to properly remove the version in the service URL, this should also be backward-compatible. \n\nCan I ask you opinion regarding this approach / issue?\n\nThank you.",
|
"message": "Hi Martin,\n\nIn our cloud, we\u0027ve configured our endpoints to have path based suffixes (e.g. `http://IP:PORT/\u003csome_path\u003e/v2`), and the discovery tool isn\u0027t working properly with this kind of endpoints because it cuts too much (`\u003csome_path\u003e/v2` this is example) when the port is **not** None. I tried to work around this by using `utils.get_base_url` instead of `no_port_cut_url` to properly remove the version in the service URL, this should also be backward-compatible. \n\nCan I ask you opinion regarding this approach / issue?\n\nThank you.",
|
||||||
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "4ef014d5_9412aa54",
|
||||||
|
"filename": "/PATCHSET_LEVEL",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 0,
|
||||||
|
"author": {
|
||||||
|
"id": 32363
|
||||||
|
},
|
||||||
|
"writtenOn": "2023-11-29T21:43:48Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "These changes seem reasonable to me.",
|
||||||
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
Loading…
Reference in New Issue