openinfra
/
python-tempestconf
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 10459 <10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 8367 <8367@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 8367 \u003c8367@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Martin Kopec replied on the change"}
Attention: {"person_ident":"Gerrit User 22873 \u003c22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Martin Kopec replied on the change"}
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Martin Kopec replied on the change"}
Attention: {"person_ident":"Gerrit User 21187 \u003c21187@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Martin Kopec replied on the change"}
This commit is contained in:
Gerrit User 22873 2022-03-29 09:04:25 +00:00 committed by Gerrit Code Review
parent 3f9f91f499
commit 5f875204c5
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5ffde61b69cf79547c9cd1da731b62d99da0c762
View File

@ -51,6 +51,24 @@
"message": "Thanks for looking into this issue and fixing it. ",
"revId": "5ffde61b69cf79547c9cd1da731b62d99da0c762",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3736af5a_567a826e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 22873
},
"writtenOn": "2022-03-29T09:04:25Z",
"side": 1,
"message": "the issue wasn\u0027t related to the fact you have many resources.\n\nwell, the test was complaining that makedirs wasn\u0027t called as the test expected, so I went line by line in the test and in the tested method and found an if statement which called the makedirs if the provided path didn\u0027t exist - then i checked what path we use in the tests and found out that /img/ which is used by the tests actually exists on your environment, which lead to the fact that makedirs wasn\u0027t executed ...",
"parentUuid": "7b48037c_c124269d",
"revId": "5ffde61b69cf79547c9cd1da731b62d99da0c762",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}