Update patch set 2
Patch Set 2: Code-Review-1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 10459 <10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
3c2264ec89
commit
66c8102678
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "cb401b3e_580ecaf9",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 10459
|
||||
},
|
||||
"writtenOn": "2021-11-29T12:07:02Z",
|
||||
"side": 1,
|
||||
"message": "Does it mean the option is enabled by default in all OSP version supported, regardless of the way they were installed? \nI see this is enabled since victoria - does it mean we need to stop supporting ussuri? That would need at least a release note. For sure the change needs a reference to the change where this option is always enabled . Can the property be dynamically discovered?\n\nAlso, please fix the commit message when you remove the WIP - the first line should explain what\u0027s going on at a glance, see for example:\nhttps://review.opendev.org/c/openinfra/python-tempestconf/+/775195\nhttps://review.opendev.org/c/openinfra/python-tempestconf/+/720093\n\n",
|
||||
"revId": "fae16bec4942d2ba8714911dda512d94702d1051",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue