diff --git a/aa037e9ce093e87a7b22000c4013be247c645b71 b/aa037e9ce093e87a7b22000c4013be247c645b71 index f6366300..04165f1c 100644 --- a/aa037e9ce093e87a7b22000c4013be247c645b71 +++ b/aa037e9ce093e87a7b22000c4013be247c645b71 @@ -84,6 +84,24 @@ "message": "Does this affect other services too? I see share.py which follows the same pattern, but I haven\u0027t checked.\n\nWould it make sense to add unit tests?\nAnd a release note?", "revId": "aa037e9ce093e87a7b22000c4013be247c645b71", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "54f42403_2af2e22a", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 35007 + }, + "writtenOn": "2023-12-01T03:31:37Z", + "side": 1, + "message": "\u003e Does this affect other services too?\n\nPossibly yes, but in our cloud we don\u0027t have `ShareService` so I did not see it as part of the story.\n\n\u003e Would it make sense to add unit tests?\n\nYes, I initially thought of adding one, but not exactly sure how can I do it easily without copy-and-pasting the test because the test is intended to test *one* possible pattern of [FAKE_URL](https://opendev.org/openinfra/python-tempestconf/src/branch/master/config_tempest/tests/services/test_compute.py#L28), do you happen to have some suggestions?\n\n\u003e And a release note?\n\nI am assuming it\u0027s for the maintainer?", + "parentUuid": "6a265ffb_e6c1d457", + "revId": "aa037e9ce093e87a7b22000c4013be247c645b71", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file