From 8e7c6704f9776df243d582fce834ef7933c761e8 Mon Sep 17 00:00:00 2001 From: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 10 Jan 2022 08:13:50 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: Code-Review+1 (3 comments) Patch-set: 3 Reviewer: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 30742 \u003c30742@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Marios Andreou replied on the change"} Attention: {"person_ident":"Gerrit User 8449 \u003c8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Marios Andreou replied on the change"} --- b284f4f7b7dfdce06054bdb546956d9c11832e32 | 63 ++++++++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/b284f4f7b7dfdce06054bdb546956d9c11832e32 b/b284f4f7b7dfdce06054bdb546956d9c11832e32 index c0312479..06424b48 100644 --- a/b284f4f7b7dfdce06054bdb546956d9c11832e32 +++ b/b284f4f7b7dfdce06054bdb546956d9c11832e32 @@ -51,6 +51,69 @@ "parentUuid": "a63f81dd_11f9b976", "revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "b6050ed7_5c2e0b81", + "filename": "config_tempest/services/image.py", + "patchSetId": 3 + }, + "lineNbr": 69, + "author": { + "id": 8449 + }, + "writtenOn": "2022-01-10T08:13:50Z", + "side": 1, + "message": "is that extra line intentional?", + "revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "00abe89a_063e4e9e", + "filename": "config_tempest/services/image.py", + "patchSetId": 3 + }, + "lineNbr": 87, + "author": { + "id": 8449 + }, + "writtenOn": "2022-01-10T08:13:50Z", + "side": 1, + "message": "do we need to worry about this being null or 0 ?", + "range": { + "startLine": 87, + "startChar": 12, + "endLine": 87, + "endChar": 18 + }, + "revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "f2a20faf_dab856f8", + "filename": "config_tempest/services/image.py", + "patchSetId": 3 + }, + "lineNbr": 90, + "author": { + "id": 8449 + }, + "writtenOn": "2022-01-10T08:13:50Z", + "side": 1, + "message": "I think it is good to return any info provided by the actual exception too wdyt?\n\n except exceptions.Forbidden as e:\n C.LOG.info(\u0027Can not retrieve stores, user are not allowed \u0027 + str(e))", + "range": { + "startLine": 90, + "startChar": 0, + "endLine": 90, + "endChar": 3 + }, + "revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file