Browse Source

Update patch set 4

Patch Set 4: Code-Review-1

(2 comments)

Patch-set: 4
Reviewer: Gerrit User 9303 <9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
changes/69/820169/meta
Gerrit User 9303 4 months ago committed by Gerrit Code Review
parent
commit
9ab694a8ca
  1. 44
      950f8ed240e7708e2a45b509d388789dc59a5dc3

44
950f8ed240e7708e2a45b509d388789dc59a5dc3

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "edd606b9_7cbde226",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 9303
},
"writtenOn": "2022-01-10T14:18:24Z",
"side": 1,
"message": "Also you are getting response from stores-info API means multiple stores are configured,So IMO no need to check whether length is 1 or \u003e 1.\n ",
"revId": "950f8ed240e7708e2a45b509d388789dc59a5dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a64d66d1_2f4dcc6b",
"filename": "config_tempest/services/image.py",
"patchSetId": 4
},
"lineNbr": 61,
"author": {
"id": 9303
},
"writtenOn": "2022-01-10T14:18:24Z",
"side": 1,
"message": "Please refer to my comment from previous PS",
"range": {
"startLine": 61,
"startChar": 8,
"endLine": 61,
"endChar": 26
},
"revId": "950f8ed240e7708e2a45b509d388789dc59a5dc3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
Loading…
Cancel
Save