openinfra
/
python-tempestconf
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(1 comment)

Patch-set: 13
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Abhishek Kekane replied on the change"}
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Abhishek Kekane replied on the change"}
This commit is contained in:
Gerrit User 9303 2022-02-17 10:58:22 +00:00 committed by Gerrit Code Review
parent ebe466de46
commit c5303b88f7
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
c72239914116fde2e4a90bedd1b14b2f263aae47
View File

@ -279,6 +279,24 @@
"parentUuid": "331d5110_78eb83c2",
"revId": "c72239914116fde2e4a90bedd1b14b2f263aae47",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "68be3dd3_224cacfd",
"filename": "config_tempest/services/image.py",
"patchSetId": 13
},
"lineNbr": 61,
"author": {
"id": 9303
},
"writtenOn": "2022-02-17T10:58:22Z",
"side": 1,
"message": "\u003e Thanks, so \"1) import image works a) if glance is configured through multistore configuration, regardless of the amount of storages (one or more) \n\u003e This is correct\"\n\u003e \n\u003e Then at least the commit message should be changed.\"\n\u003e This is an attempt to populate tempestconf with\n\u003e multistore feature enabled if and only if multiple\n\u003e stores are available.\"\n\u003e \n\u003e But then, shouldn\u0027t the function be check whether the feature is enabled, and be called differently (_is_multistore_enabled) rather then checking the amount of stores?\n\nAgree, As per the commit message I thought the patch is to check if multistore is configured but internally it seems to run import workflow like import images in more than one store or copying existing images in more than one store. I think we should add a note here to explain why we need more than 1 store and set it here if num_stores \u003e 1.",
"parentUuid": "e764b1ae_808b7bb0",
"revId": "c72239914116fde2e4a90bedd1b14b2f263aae47",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}