openinfra
/
python-tempestconf
Code Issues Proposed changes

Update patch set 13 

Patch Set 13: Code-Review-1

(1 comment)

Patch-set: 13
Reviewer: Gerrit User 10459 <10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 10459 \u003c10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Luigi Toscano replied on the change"}
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Luigi Toscano replied on the change"}
This commit is contained in:
Gerrit User 10459 2022-02-17 10:21:45 +00:00 committed by Gerrit Code Review
parent d791182731
commit ebe466de46
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
c72239914116fde2e4a90bedd1b14b2f263aae47
View File

@ -261,6 +261,24 @@
"parentUuid": "5e3f7e1d_6551b7a1",
"revId": "c72239914116fde2e4a90bedd1b14b2f263aae47",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e764b1ae_808b7bb0",
"filename": "config_tempest/services/image.py",
"patchSetId": 13
},
"lineNbr": 61,
"author": {
"id": 10459
},
"writtenOn": "2022-02-17T10:21:45Z",
"side": 1,
"message": "Thanks, so \"1) import image works a) if glance is configured through multistore configuration, regardless of the amount of storages (one or more) \nThis is correct\"\n\nThen at least the commit message should be changed.\"\nThis is an attempt to populate tempestconf with\nmultistore feature enabled if and only if multiple\nstores are available.\"\n\nBut then, shouldn\u0027t the function be check whether the feature is enabled, and be called differently (_is_multistore_enabled) rather then checking the amount of stores?",
"parentUuid": "331d5110_78eb83c2",
"revId": "c72239914116fde2e4a90bedd1b14b2f263aae47",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}