{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "2bc46b2a_30ce78c1",
        "filename": "config_tempest/services/image.py",
        "patchSetId": 7
      },
      "lineNbr": 89,
      "author": {
        "id": 9303
      },
      "writtenOn": "2022-01-11T06:36:36Z",
      "side": 1,
      "message": "I think you should catch generic exception here, because actual glance API is raising NotFound if multiple stores are not configured, also a work is going on to check policy rule which will raise forbidden to restrict users from accessing the information.\n\nI think this should be like;\nstores \u003d None\ntry:\n    stores \u003d self.client.info_stores()[\u0027stores\u0027]\nexcept Exception:\n    C.LOG.info(\u0027Can not retrieve stores, either multiple stores are not configured or user are not allowed access stores information\u0027)\n    return stores\n\nreturn len(stores)",
      "range": {
        "startLine": 85,
        "startChar": 8,
        "endLine": 89,
        "endChar": 71
      },
      "revId": "1bd900a36c502787b3499a7f0ab5672962dfc97b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4deb400f_99ee726c",
        "filename": "config_tempest/services/image.py",
        "patchSetId": 7
      },
      "lineNbr": 89,
      "author": {
        "id": 30742
      },
      "writtenOn": "2022-01-11T10:32:37Z",
      "side": 1,
      "message": "What if we catch the same exception which glance API would throw?",
      "parentUuid": "2bc46b2a_30ce78c1",
      "range": {
        "startLine": 85,
        "startChar": 8,
        "endLine": 89,
        "endChar": 71
      },
      "revId": "1bd900a36c502787b3499a7f0ab5672962dfc97b",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}