78 lines
2.8 KiB
Plaintext
78 lines
2.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d21302e3_db065bc0",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 8367
|
|
},
|
|
"writtenOn": "2021-11-30T12:04:20Z",
|
|
"side": 1,
|
|
"message": "Attempt you mean, you\u0027re not sure if this will fix the problem for Centos 9? Do we have a testproject testing it on Centos 7, 8 and 9? We can\u0027t fix it for Centos 9 and break for the other previous versions.",
|
|
"range": {
|
|
"startLine": 14,
|
|
"startChar": 15,
|
|
"endLine": 15,
|
|
"endChar": 11
|
|
},
|
|
"revId": "1152704e2f97f81af06fa4983ef4393f5bcc339d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2a6eaa28_6d82585d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 10459
|
|
},
|
|
"writtenOn": "2021-11-30T11:46:43Z",
|
|
"side": 1,
|
|
"message": "Please change the first line as I explained before.\n\nMoreover, the need for something in c9 is not a reason for this change. If the parameter is missing in some specific deployment, then it should be added to that deployment, unless it can be detected.\n\nIf you think this is the new default and should be changed for this reason, please explain why.",
|
|
"revId": "1152704e2f97f81af06fa4983ef4393f5bcc339d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "44631f36_52df704d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 8367
|
|
},
|
|
"writtenOn": "2021-11-30T12:07:12Z",
|
|
"side": 1,
|
|
"message": "If this affect only centos-9 on tripleo, we can add it on the job definition there is the tempest_tempestconf_profile_overrides variable.\nSee an example in https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/general_config/featureset062.yml#L82",
|
|
"revId": "1152704e2f97f81af06fa4983ef4393f5bcc339d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "849ad97f_2788e277",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 62,
|
|
"author": {
|
|
"id": 8367
|
|
},
|
|
"writtenOn": "2021-11-30T12:04:20Z",
|
|
"side": 1,
|
|
"message": "Please move this up and add proper comments. The comment above is for the line below, make it confuse for people in the future",
|
|
"revId": "1152704e2f97f81af06fa4983ef4393f5bcc339d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |