89 lines
2.9 KiB
Plaintext
89 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4a531354_ea420ed5",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 35007
|
|
},
|
|
"writtenOn": "2023-11-29T03:38:35Z",
|
|
"side": 1,
|
|
"message": "Hi Martin,\n\nIn our cloud, we\u0027ve configured our endpoints to have path based suffixes (e.g. `http://IP:PORT/\u003csome_path\u003e/v2`), and the discovery tool isn\u0027t working properly with this kind of endpoints because it cuts too much (`\u003csome_path\u003e/v2` this is example) when the port is **not** None. I tried to work around this by using `utils.get_base_url` instead of `no_port_cut_url` to properly remove the version in the service URL, this should also be backward-compatible. \n\nCan I ask you opinion regarding this approach / issue?\n\nThank you.",
|
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4ef014d5_9412aa54",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32363
|
|
},
|
|
"writtenOn": "2023-11-29T21:43:48Z",
|
|
"side": 1,
|
|
"message": "These changes seem reasonable to me.",
|
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5792922a_05c60e16",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 22873
|
|
},
|
|
"writtenOn": "2023-11-30T13:02:00Z",
|
|
"side": 1,
|
|
"message": "looks reasonable and the gates seem to agree",
|
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cbae9b89_70d0c807",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 22873
|
|
},
|
|
"writtenOn": "2023-11-30T13:02:07Z",
|
|
"side": 1,
|
|
"message": "check experimental",
|
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6a265ffb_e6c1d457",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 10459
|
|
},
|
|
"writtenOn": "2023-11-30T13:28:28Z",
|
|
"side": 1,
|
|
"message": "Does this affect other services too? I see share.py which follows the same pattern, but I haven\u0027t checked.\n\nWould it make sense to add unit tests?\nAnd a release note?",
|
|
"revId": "aa037e9ce093e87a7b22000c4013be247c645b71",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |