208 lines
6.2 KiB
Plaintext
208 lines
6.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5c427a9f_fd4545e1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 19138
|
|
},
|
|
"writtenOn": "2022-01-06T12:18:38Z",
|
|
"side": 1,
|
|
"message": "Looks good to me but yes as Alex mentioned, need to check why it\u0027s failing.",
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a63f81dd_11f9b976",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 22873
|
|
},
|
|
"writtenOn": "2022-01-06T13:19:28Z",
|
|
"side": 1,
|
|
"message": "the gate failures don\u0027t seem to be related to this change, i\u0027m testing the gate\u0027s health in another change",
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1e8c25b9_68b6da67",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 30742
|
|
},
|
|
"writtenOn": "2022-01-06T14:37:40Z",
|
|
"side": 1,
|
|
"message": "yeah..i also think python-tempestconf gate is not very stable",
|
|
"parentUuid": "a63f81dd_11f9b976",
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4855f0fd_fdc336af",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 62,
|
|
"author": {
|
|
"id": 9303
|
|
},
|
|
"writtenOn": "2022-01-10T14:12:49Z",
|
|
"side": 1,
|
|
"message": "There is a possibility that I can configure multiplestores with actual single store in it;\nLike;\n\nenabled_backends \u003d efficient:rbd\n\nAlso going forward we are going to get rid of old way of store configuration, so devstack will define default store as \n\nenabled_backends \u003d default:file\n\nI think this code should be generic and should work with num_stores \u003d\u003d 1",
|
|
"range": {
|
|
"startLine": 60,
|
|
"startChar": 8,
|
|
"endLine": 62,
|
|
"endChar": 69
|
|
},
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b6050ed7_5c2e0b81",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 69,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2022-01-10T08:13:50Z",
|
|
"side": 1,
|
|
"message": "is that extra line intentional?",
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d71348cf_9dc0c206",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 69,
|
|
"author": {
|
|
"id": 30742
|
|
},
|
|
"writtenOn": "2022-01-10T12:48:07Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "b6050ed7_5c2e0b81",
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "00abe89a_063e4e9e",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 87,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2022-01-10T08:13:50Z",
|
|
"side": 1,
|
|
"message": "do we need to worry about this being null or 0 ?",
|
|
"range": {
|
|
"startLine": 87,
|
|
"startChar": 12,
|
|
"endLine": 87,
|
|
"endChar": 18
|
|
},
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2efad8d4_cdc04f61",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 87,
|
|
"author": {
|
|
"id": 30742
|
|
},
|
|
"writtenOn": "2022-01-10T12:48:07Z",
|
|
"side": 1,
|
|
"message": "IMO, we don\u0027t need to worry about \u0027stores\u0027 value being null or 0 since we want to check weather this value is greater than 1. If it is 1 or less than 1 i.e 0 or null we won\u0027t enable the multi-store feature.",
|
|
"parentUuid": "00abe89a_063e4e9e",
|
|
"range": {
|
|
"startLine": 87,
|
|
"startChar": 12,
|
|
"endLine": 87,
|
|
"endChar": 18
|
|
},
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f2a20faf_dab856f8",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 90,
|
|
"author": {
|
|
"id": 8449
|
|
},
|
|
"writtenOn": "2022-01-10T08:13:50Z",
|
|
"side": 1,
|
|
"message": "I think it is good to return any info provided by the actual exception too wdyt?\n\n except exceptions.Forbidden as e:\n C.LOG.info(\u0027Can not retrieve stores, user are not allowed \u0027 + str(e))",
|
|
"range": {
|
|
"startLine": 90,
|
|
"startChar": 0,
|
|
"endLine": 90,
|
|
"endChar": 3
|
|
},
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "df9e489d_94bbe613",
|
|
"filename": "config_tempest/services/image.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 90,
|
|
"author": {
|
|
"id": 30742
|
|
},
|
|
"writtenOn": "2022-01-10T12:48:07Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "f2a20faf_dab856f8",
|
|
"range": {
|
|
"startLine": 90,
|
|
"startChar": 0,
|
|
"endLine": 90,
|
|
"endChar": 3
|
|
},
|
|
"revId": "b284f4f7b7dfdce06054bdb546956d9c11832e32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |