openinfra
/
refstack
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: I would prefer that you didn't merge this

(3 inline comments)

please address my comments about exceptions.

Patch-set: 2
Reviewer: Gerrit User 6287 <6287@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 6287 2014-04-08 17:11:16 +00:00 committed by Gerrit Code Review
parent e295992b61
commit 30f7479a8d
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
d13ae394c246a2472c02fd497e9eea0e5b1c6305 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "AAAAWn//5N4\u003d",
"filename": "refstack/tools/execute_test.py",
"patchSetId": 2
},
"lineNbr": 248,
"author": {
"id": 6287
},
"writtenOn": "2014-04-08T17:11:16Z",
"side": 1,
"message": "please be specific with exceptions! what are you really catching for? try to think through all the possible failures and have an exception for each.",
"revId": "d13ae394c246a2472c02fd497e9eea0e5b1c6305",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWn//5N0\u003d",
"filename": "refstack/tools/execute_test.py",
"patchSetId": 2
},
"lineNbr": 265,
"author": {
"id": 6287
},
"writtenOn": "2014-04-08T17:11:16Z",
"side": 1,
"message": "please be specific with exceptions! what are you really catching for? try to think through all the possible failures and have an exception for each.",
"revId": "d13ae394c246a2472c02fd497e9eea0e5b1c6305",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWn//5Pw\u003d",
"filename": "refstack/tools/execute_test.py",
"patchSetId": 2
},
"lineNbr": 345,
"author": {
"id": 6287
},
"writtenOn": "2014-04-08T17:11:16Z",
"side": 1,
"message": "please be specific about what you are catching for.. is this for a key error?",
"revId": "d13ae394c246a2472c02fd497e9eea0e5b1c6305",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}