Update patch set 1
Patch Set 1: (10 inline comments) updated the code Patch-set: 1
This commit is contained in:
Gerrit User 10003
Gerrit Code Review
parent
9fbbc74ba7
commit
43f32fce4c
|
|
@ -17,6 +17,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dRg\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 35,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "AAAAVn//gYY\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gcY\u003d",
|
||||
|
|
@ -34,6 +52,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dRw\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 45,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "agree",
|
||||
"parentUuid": "AAAAVn//gcY\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gVY\u003d",
|
||||
|
|
@ -69,6 +105,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//cOM\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 61,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "point taken. I updated the code",
|
||||
"parentUuid": "AAAAVn//eJg\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gqU\u003d",
|
||||
|
|
@ -86,6 +140,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dOk\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "Yes, we decided for the certification to run the full test.\nTo run a full test, the higher level code can simply pass in one testcase - \"tempest\".\nThis code is written for flexibility and supporting different use cases, eg. vendor testing during development.\nDifferent vendors may customize the set of testcases that they want to test, for example, only testing API.",
|
||||
"parentUuid": "AAAAVn//gqU\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gqQ\u003d",
|
||||
|
|
@ -103,6 +175,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dNA\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "see comment above.",
|
||||
"parentUuid": "AAAAVn//gqQ\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gd8\u003d",
|
||||
|
|
@ -120,6 +210,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dH0\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 102,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "The \"try\" is now moved inside the for loop.\nIf one testcase fails, it will continue to the next testcase.",
|
||||
"parentUuid": "AAAAVn//gd8\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gds\u003d",
|
||||
|
|
@ -137,6 +245,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dGQ\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 103,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "AAAAVn//gds\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//ghk\u003d",
|
||||
|
|
@ -154,6 +280,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dGA\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 115,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "agree",
|
||||
"parentUuid": "AAAAVn//ghk\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gkg\u003d",
|
||||
|
|
@ -171,6 +315,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dEI\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 123,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "AAAAVn//gkg\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//gaw\u003d",
|
||||
|
|
@ -187,6 +349,24 @@
|
|||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAVn//dD4\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 136,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-03-06T04:12:20Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "AAAAVn//gaw\u003d",
|
||||
"revId": "2985b6919d2de824f6436d9927d79c346a5c8435",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue