Update patch set 5

Patch Set 5: Code-Review-1

(3 comments)

Patch-set: 5
Reviewer: Gerrit User 22873 <22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 22873 \u003c22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Martin Kopec replied on the change"}

9ead087c5c54ccaf5f05ff8fa4479d9ffbf1b8cd

@@ -0,0 +1,61 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "c7136237_10b9129b",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 5
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 22873
+      },
+      "writtenOn": "2021-10-13T12:03:12Z",
+      "side": 1,
+      "message": "it\u0027s on a great way, looks good .. however I would suggest to create index.rst only in case we have a dir with at least one more file - e.g. doc/source/run_in_docker is a great example, there are 2 files and the index.rst within the dir puts the other doc files together (imports them) which simplifies the import of the run_in_docker docs - we need to import only the index file and don\u0027t need to import the others within the run_in_docker dir \n\n.. that said, i find it a little overkill to create a new dir for just one .rst file - as it\u0027s in the case of how_to_upload_test_results\n\nsee f.e. python-tempestconf\u0027s example for analogy: https://opendev.org/osf/python-tempestconf/src/branch/master/doc/source",
+      "revId": "9ead087c5c54ccaf5f05ff8fa4479d9ffbf1b8cd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "075040c5_8ae05695",
+        "filename": "doc/source/conf.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 35,
+      "author": {
+        "id": 22873
+      },
+      "writtenOn": "2021-10-13T12:03:12Z",
+      "side": 1,
+      "message": "what about the openstackdocstheme options on lines 62-64?",
+      "revId": "9ead087c5c54ccaf5f05ff8fa4479d9ffbf1b8cd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "46f07b90_fd7dd444",
+        "filename": "doc/source/vendor_product_management/VendorEntity.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 22873
+      },
+      "writtenOn": "2021-10-13T12:03:12Z",
+      "side": 1,
+      "message": "I think you can use \"\u003d\u003d\u003d\" again, you don\u0027t need to take into account that this file is nested under other titles, see f.e. python-tempestconf for analogy:  https://opendev.org/osf/python-tempestconf/src/branch/master/doc/source",
+      "range": {
+        "startLine": 2,
+        "startChar": 0,
+        "endLine": 2,
+        "endChar": 13
+      },
+      "revId": "9ead087c5c54ccaf5f05ff8fa4479d9ffbf1b8cd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}